Andrea Aime wrote: > Well, > added the cache, down to 40 seconds. Where are those 40 seconds > spent? Creating property accessors, and trying to convert a Double > to double/float going thru a String object! > Don't you believe me? See: We believe you :-) In fact we were waiting for you.
Andrea I know we should take a run through this API with performance in mind; I am not sure if you caught it last week but we found an actual hole in our implementation of Function last week. Right now I am looking at using the same solution as applied here for property accessors (ie a lazy lookup). I am sure holding onto the "binding" after a lazy lookup would be an easy performance boost. Do you want to look into solutions for Function at this time? Jody > Pattern matching is expensive, and this property accessor creation > code is run in our innermost loop... I'll try to fix this one too, > but I'm wondering, what's the acceptable balance between performance > and flexibility? This is more a case of *accuracy* - Justin was on a deadline here so be kind :-) The existing Filter implementation was quick short and brutal (and apparently fast). The months spend slogging through the Filter 1.1 specification and cite tests were really good for making our implementation accurate as well. Aside: I am not sure how much of the CITE tests justin got captured as JUnit - it should be pretty good and we made "acceptance tests" as part of our RnD pages. > mho, but with changes like these, we're going to become slower > than the first dummy renderer we had 4 years ago... Once again, priorities + deadline + no community on trunk. Now that we are *on* trunk we have to pay attention to work like this as it has consequences. Indeed Gabriel is going though all these kinds of tradeoffs right now - we should be sure to watch his email. Jody ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
