Well for now Andreas patch is fine. It was just a few minor optimizations which doesn't change the functionality of the code, so that is cool.
However... this issue is far from solved. Because there is an extension point there the renderer is vulnerable to somone adding in a very slow property accessor. For instance, in the xml-xsd module there is a property accessor for doing full xpath queries, which is slow. So i literally dont know what will happen if someone tries to render with xml-xsd on the classpath. This is a tough problem. I can think of two solutions. The first is to not have the renderer go through expression to get the value of a feature attribute. Just call getAttribute directly. I expect Jody ( and perhaps others ) to not like this approach as it means the render can only handle truly simple features. It does however ensure that feature property access will always be fast. The second is to pass in a hint whenever a property expression is evaluated. Which with our expression api is not possible. We would need a method like: Expression#evaluate( Object, Class, Hints ); Which we don't have. -Justin Andrea Aime wrote: > Jody Garnett ha scritto: >> Andrea Aime wrote: >>> Sure, but I have no time to put on this. Versioning WFS has been delayed >>> due to 1.5.x release and trunk merge, now I have to work on it full >>> steam. >> Andrea I am not asking for your time - I am asking for your >> consideration of a solution. I was unable to tell from this email >> thread what solution you and Justin have applied to the property >> access performance problem. >> >> Justin proposed two approaches, I commented on them, did you guys do >> something already? >> >> (Is there a bug report I can track the progress on - rather then hunt >> through this email) > > Nope, there's nothing going on. > I can't really see a solution for it on the top of my head now, > but Justin seems to have ideas. Justin? > Cheers > Andrea > > !DSPAM:1004,45d2cc5e306974820651628! > -- Justin Deoliveira [EMAIL PROTECTED] The Open Planning Project http://topp.openplans.org ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
