Cool let me just confirm my thinking with Mauricio then. Mauricio - I like CQL a lot and plan to use it in all the sample code. As such users are going to be using it everywhere. A year from now most won't actually know what a FilterFactory is ... because they never will of used it.
As such I would like to pay attention to what the sample code looks like, right down to number of keypresses. And we make the decision on what to call CQLParser based on porting some filter examples into the demo/intro and the user docs? Just a couple of pages should do the trick. Cheers, Jody > Hi Jody, > > On Friday 23 February 2007 01:41, Jody Garnett wrote: > >> Sorry for the delay Gabriel ... >> > no need to apologize > >> a lot of your patch was directed at >> Expr. Is that file still around? trunk says no ... >> > Correct, trunk is ok, I've already fixed the issues with functions and the > like a time ago, and Expr functionality in trunk is directly incorporated in > FilterFactoryImpl. The patch was mainly a backport of the funciton finder on > trunk as an inner class for Expr in 2.3.x, since 2.3.x was not creating > functions at all. > > >> Right now cql is commented out of the build; what needs to happen for it >> to be brought into the build, and then supported? >> > > Guess just changing the name of FilterBuilder to CQL as you suggested. > Mauricio would be happier with CQLParser, but not a great deal anyway. > > So watever of the two seems better we can make the change and move the module > to plugin asap. > > cheers, > > Gabriel > >> Jody >> >> >>> Hi all, >>> >>> I'm being asked by Andrea to back port the CQL module from trunk to 2.3.x >>> so we can use it on GeoServer 1.5.x >>> >>> So I went ahead and did it on my box. Now, I had to fill a couple holes >>> in Expr.java in order to actually create functions, and had to add >>> boolean and date literal types for LiteralExpression. >>> >>> Attached are the patches that make the trick. Applying them on my box and >>> running mvn clean install from the root pom works just fine. >>> >>> Please review as I'm waiting for the go ahead or not to commit this >>> changes and upload the cql module on trunk. >>> >>> Cheers, >>> >>> Gabriel >>> ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
