IndexInfo checks for collection not being emtpy forcing an unecessary disk 
access
---------------------------------------------------------------------------------

                 Key: GEOT-1473
                 URL: http://jira.codehaus.org/browse/GEOT-1473
             Project: GeoTools
          Issue Type: Bug
          Components: ext shapefilerender
    Affects Versions: 2.4-RC0
            Reporter: Andrea Aime
            Assignee: Jesse Eichar
             Fix For: 2.4-RC1


IndexInfo.queryQuadTree(bboxs) grabs the query results and checks if the 
collection is not empty forcing a disk access. This is unecessary since the 
rest of the code is pretty much capable of handling an empty collection and the 
qtree will get closed anyways as far as I can see.

This optimization is not as major as the previous ones, but gives some 20% 
speedup in benchmarks that do access a very small part of the original data 
(that is, those where accessing the index is more expensive than actually 
accessing the data), and brings GeoServer a little more closer to MapServer 
performance.

I'm going to commit it, but I don't feel super sure about this one. If you have 
little time, can you just review this one?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to