Hi andrea. I'll take a look at that next.
As for the shapefile plugin. I've got that going with no warnings. I also cleaned it up so that if you call ShapefileDatastore.dispose() you will not get two messages about the unreleased locks. Just one. Jesse Le 16-Jan-08 à 12:36 AM, Andrea Aime a écrit : > Jesse Eichar ha scritto: >> Hi All, >> I've got all the shapefile tests passing. But I have added a >> new .... "feature"? >> The shapefile datastore.dispose() method check if all the locks >> have been released and if not logs a big log. Also the finalizer >> logs the same log. >> So the massive log is being printed numerous times because there is >> a problem that I have yet to address when reading a shapefile in a >> jar. >> I am working on the issue and tomorrow hopefully there will be no >> more warning. But beware when you start using it and don't close >> all the readers you will get a very large error log. Fortunately >> there is a stack trace of when the lock occurred so you can easily >> find the reader/writer that wasn't closed. >> But hold off until I finish the shapefile datastore work please. >> (or don't complain to me if the fault actually lies in the >> datastore) > > Jesse, I'm happy to report the shapefile module builds on my pc. > Yet the shapefile renderer does not with the following failure: > > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 0.016 sec > Running org.geotools.renderer.shape.ShapeRendererTest > Count: 3 > Count: 3 > failed to delete: C:\progetti\geotools\trunk\modules\extension > \shapefile-renderer\target\test-classes\org\geotools\renderer\shape > \test-data\theme246708.prj > Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 0.281 sec <<< FAILURE! > Running org.geotools.data.shapefile.shp.SimpleMultiPointHandlerTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: > 0.016 sec > Running org.geotools.renderer.shape.ScreenMapTest > Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec > Running org.geotools.data.shapefile.shp.SimplePointHandlerTest > Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec > Results : > Tests run: 48, Failures: 1, Errors: 0, Skipped: 0 > > and the surefire report is: > > ------------------------------------------------------------------------------- > Test set: org.geotools.renderer.shape.ShapeRendererTest > ------------------------------------------------------------------------------- > Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: > 0.281 sec <<< FAILURE! > testRemoveTransaction(org.geotools.renderer.shape.ShapeRendererTest) > Time elapsed: 0.203 sec <<< FAILURE! > junit.framework.AssertionFailedError: expected:<2> but was:<3> > at junit.framework.Assert.fail(Assert.java:47) > at junit.framework.Assert.failNotEquals(Assert.java:282) > at junit.framework.Assert.assertEquals(Assert.java:64) > at junit.framework.Assert.assertEquals(Assert.java:201) > at junit.framework.Assert.assertEquals(Assert.java:207) > at > org > .geotools > .renderer > .shape > .ShapeRendererTest.testRemoveTransaction(ShapeRendererTest.java:255) > > I had a quick look and it does not seem to be related to my > yesterday's geometric filter handling fixes. > > Cheers > Andrea ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
