Hi, I've read the proposal, I have two concerns. The first one has already been voiced by Jody, whenever the Metadata classes are used, they should be used as interfaces and be created with a factory, otherwise we'd tangle up GeoTools code and make it difficult for future evolution. See what happened for filters for example, we had quite some issues because of code that assumed implementations instead of interfaces and worked only with them, try to roll your own specific implementation and you're screwed. If the interface is not good enough to be used directly, maybe it's time to fix the interface? There is one important detail here that I'm not sure about thought, which is how widely the metadata classes are used, for what, and what is the intended way to use them... I'm used to see filters, styles and so on used thru interfaces, so I may be trying to draw the wrong parallel.
The second one is that this change does not actually introduce any extra functionality, does not fix any major bug, but "only" makes for a more consistent class naming. The fact that classes are implementing "geoapi" is kind of an arbitrary way to delineate them to me, this kind of coding convention should be established project wide. For example, what about the style classes? They all use ...Impl as well, does this mean that we need to change all of them too when the SE 1.1 goes on? I actually agree that having consistent naming is important, makes for more readable and usable code, but I'm worried because it is bound to cause trouble in all projects using gt2 again. How many classes is this going to touch, can we reasonably expect to have a semi-automatic way for people to upgrade their code? In some way it's similar to the feature model changes, but that was the first step to introduce new major functionality, and one can just go from Feature to SimpleFeature and FeatureType to SimpleFeatureType automatically, and then fix the feature building and bbox handling manually, so the process can be at least partly automated. Again, I don't know how many people will be affected by changes in the changes of the metadata module, so I may be overestimating the issue. Cheers Andrea ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
