Let the data source handle the connection isolation
---------------------------------------------------
Key: GEOT-2021
URL: http://jira.codehaus.org/browse/GEOT-2021
Project: GeoTools
Issue Type: Improvement
Components: data h2
Affects Versions: 2.5.0, 2.6-M0
Reporter: Andrea Aime
Assignee: Andrea Aime
Fix For: 2.5.0, 2.6-M0
Setting the connection isolation in JDBCDataStore.createConnection is
problematic for two reasons:
- it is a performance bottleneck in Oracle, where calling the method issues a
communication with the server
- may override whatever was already set in an external connection pool, with
unexpected consequences for the user
So I suggest we simply remove it, and set the isolation level in the connection
pool creation (BasicDataSource.setDefaultTransactionIsolation) if the default
one of the driver is not satisfactory.
I've already done so in my checkout and found no adverse consequences with H2
or Oracle.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
