Emily Gouge ha scritto: > I was having an issue in uDig with loading WFS data. > > The problem boiled down to Geotools trying to encode a filter that > looked similar to "Filter.EXCULDES AND bbox...". This encoding failed > because "org.opengis.filter.ExcludeFilter cannot be cast to > org.geotools.filter.Filter". > > The simple solution for this was to update the StreamingRenderer to > simplify filters using the SimplifyingFilterVisitor. This simiplifies > the expression down to Filter.EXCULDES which we don't seem to have any > problems encoding.
Emily, thanks for reporting, yet the things should be handled another way. You having commit access does not mean you can commit changes at will in any module, but only in those where you are: * maintainer of the module * got permission from the maintainer to directly commit changes In all other cases you should open a jira, explain the improvement, and attach a patch for the module maintainer to apply. Eventually the module maintainer will start trusting your changes and will give you free access to his module. About this particular change, Jesse is the maintainer, but I got free access on the module as well (so if Jesse already gave you free access, I apologize for the above). The patch looks ok, but it's partial, it does not cover the case in which the wfs datastore is accessed directly (as opposed through the renderer). The simplification filter should be applied in the datastore as well, before encoding. I opened a request in this direction some time ago, but no one acted on it: http://jira.codehaus.org/browse/GEOT-1942 wfs is basically maintained by RR so you should also look into committing a patch there too (ask Jody for the get go). Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
