Hi all,

I put together a patch for the capabilities improvement described in 
http://jira.codehaus.org/browse/GEOT-2257 .  It's attached to the 
issue.  One problem that jdeolive brought up during a quick review was 
the question of what the default implementation should return.  Justin 
advocated having it return true, since consistency is part of what 
feature ids are supposed to *mean*; whereas I thought it would be better 
to have it return false since a false positive is more likely to result 
in undefined behavior than a false negative.

The other point that Justin brought up was one of style, I named the new 
method 'hasReliableFIDs()' instead of the more consistent 
'isReliableFidSupported()'.  I'm currently making this change.

Does anyone else care to weigh in?

David Winslow

------------------------------------------------------------------------------
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to