Ben Caradoc-Davies ha scritto: > As my coworker just discovered, Jalopy modifies all code, even code that > has not been changed. This is a Bad Thing. > > We both use Eclipse with the GeoTools formatter build/eclipse/formatter.xml > > Mixing and matching with Jalopy will only cause pain. I don't even want > to try it. We know it is too aggressive. As Andrea Aime wrote (on 18 > April 2008): > http://n2.nabble.com/Code-formatting-on-eclipse.-Developers-guide-need-to-be-updated--%28JALOPY%29-tp1957505p1957507.html > > > "It's ugly, not really an option imho. It will rewrite the file > completely even if it was not modified, and may introduce cross platform > issues due to newline changes. We had to stop using it in GeoServer for > that reason at least." > > Seems like a lot of people use it once, like touching an electric fence. > Warnings not to use it are circulating like Secret Programmers' > Business, and some people don't find out until it is too late. In my > view, I would warn people off it. > > If you prefer, we can post large warning signs on the wiki, but I think > we should just get rid of it.
Too bad, we really sorely miss an well working build time automated formatter: experience shows that you cannot trust people to keep consistent formatting, and once bad formatting is there, well, you usually discover it when doing a bug fix, and you don't want to mix in your diff the real fix with cosmetic changes. Anyways, I agree the way Jalopy works is simply unacceptable. So +1 on getting rid of it. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM) software. With Adobe AIR, Ajax developers can use existing skills and code to build responsive, highly engaging applications that combine the power of local resources and data with the reach of the web. Download the Adobe AIR SDK and Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
