On Monday 18 May 2009 11:14:49 Mauricio Pazos wrote: > > In the main module it's used by an old text expression > > parser that is marked as deprecated (ExpressionBuilder). > > I'd say, let's just remove it and in the few places > > where it's used, let's just build filters by code > > (cql cannot be used in main, that would cause a > > circular dependency). > > > > In the cql module it's used and I don't see an > > easy way to remove it. In particular, the parsing > > design fights again the jjtree/javacc standard > > practice and tries to replace the standard Node > > interface with a custom made one (instead of > > asking jjtree to extend a user provided base > > class) > > This is not supported by the Mojo version of the > > jjtree plugin, and results in compile failures. > > Mauricio, how hard would it be to fix this issue > > in your opinion? Hi Andrea, I was trying alternatives: 1- Create an SuperClass of SimpleNode. The compiler uses the "node id" to build the correspondent filter. The "id" is SimpleNode's instance variable, the generated SimpleNode has not any getter for id, that is the reason why we need customize it.
2- Provide a factory for node (using the NODE_FACTORY option) This have two alternative setting: a) "true" it generate a SimpleNode with the method jjCreate(int id) which should be implemented. This is not the solution required (thinking in the Mojo issue) because we need to avoid a custom SimpleNode. b) "MyFactory class" that implement jjCreate method. This could be the solution because we could provide the required Node implementation, unfortunately javacc doesn't generate the correspondent line to call the factory. I have sent an email to javacc user list. Others ideas are welcome cheers -- Mauricio Pazos www.axios.es ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
