Jody Garnett wrote:
> I am waiting on:
> - patch for events (and justin is waiting on me to make him a test
> case? showing a design problem I found - two commits are issued if you
> have two datastores on the same transaction; rather than one)
The event patch has been comitted. The double commit issue yes, i am 
still waiting on a test to replicate the problem, but the event code is 
there.

> - aggregation support; I had something but I killed it due to the
> amount of duplication

A bit stalled. There is a patch there but a couple of issues remain:

* There is an interface needed for such visitors
* There are some questions about multiple argument functions
* Some of the tests need to be guarded with a check with isLimitOffset 
supported

If people can live with single argument functions for now I will happily 
apply, adding the guard for test cases.

> - and then I noticed that the duplication between prepaired statements
> / and sql statements is actually done *everywhere*. I came up with an
> approach for this one (and submitted the code in a patch) but we are
> looking at a couple days work to clean up the the duplication. I think
> this would be worth it as there is a lot of cut and paste code around
> the handling of any statement that includes a "select XXXXX" block.
The patch was quite incomplete... and nowhere near ready to be swapped 
in for the current approach. I also have some issues with the approach 
which I raised on the issue. So I opted to stick with the current 
approach and only apply the code that actually implements aggregate 
functions.
> 
> It is the last point (and the code clean up that it represents) that
> would make comfortable proceeding.
> 
> Cheers,
> Jody
> 
> On Mon, Jun 15, 2009 at 9:17 PM, Andrea Aime<[email protected]> wrote:
>> Hi,
>> I was thinking about trunk and I'm wondering if there is
>> anything still missing in order to graduate jdbc-ng and
>> push down the old jdbc datastores in unsupported land
>> for a release cycle?
>>
>> The full list of issues against jdbc-ng is here:
>> http://jira.codehaus.org/secure/IssueNavigator.jspa?reset=true&mode=hide&pid=10270&sorter/order=DESC&sorter/field=priority&resolution=-1&component=13503
>>
>> But it seems most of them are shared with the old
>> datastores/are new features.
>>
>> Shall we make a mini-sprint to kick these fellas in
>> supported land?
>>
>> Cheers
>> Andrea
>>
>> --
>> Andrea Aime
>> OpenGeo - http://opengeo.org
>> Expert service straight from the developers.
>>
>> ------------------------------------------------------------------------------
>> Crystal Reports - New Free Runtime and 30 Day Trial
>> Check out the new simplified licensing option that enables unlimited
>> royalty-free distribution of the report engine for externally facing
>> server and web deployment.
>> http://p.sf.net/sfu/businessobjects
>> _______________________________________________
>> Geotools-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
> 
> ------------------------------------------------------------------------------
> Crystal Reports - New Free Runtime and 30 Day Trial
> Check out the new simplified licensing option that enables unlimited
> royalty-free distribution of the report engine for externally facing 
> server and web deployment.
> http://p.sf.net/sfu/businessobjects
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/geotools-devel


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables unlimited
royalty-free distribution of the report engine for externally facing 
server and web deployment.
http://p.sf.net/sfu/businessobjects
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to