Hi Andrea / Michael:

I sent you both a patch yesterday that explored the idea of
"correcting" the URL inside the ShapefileDataStore and
ShapefileDataStoreFactory; I still had to run around and fix a lot of
the test cases ... but everything did build.

Today I have a better idea; but no time to work on it.  We can put off
correcting the URL until we need to turn it into a file again; so
rather then being all worked up about an invalid URL being passed to
our code and correcting it as soon as possible; we can just let it be
and leave any corrective work until the DataUtilities.urlToFile( url )
method.

For the next while users will be using both file.toURL() (which
produces an invalid result just like the mac) and file.toURI().toURL()
(which only produces an invalid result on the mac). So being able to
handle this case would be good.

Jody

On Mon, Jun 29, 2009 at 7:46 PM, Jody Garnett<[email protected]> wrote:
> Hi Andrea:
>
> Decoding the URLs is where we spent most of our URLUtils testing pain;
> I have asked Andrea Antonello and Jesse to chime in since they have
> both spent a lot of time staring at this problem and testing on
> multiple platforms.
>
> Jody
>
> On Mon, Jun 29, 2009 at 7:21 PM, Andrea Aime<[email protected]> wrote:
>> Michael Bedward ha scritto:
>>>>
>>>> The patch is for 2.5.x
>>>>
>>>
>>> Ah, OK.  I missed that, sorry.
>>>
>>> To double check I reverted the patch then manually fixed all of the
>>> plain toURL calls in the shapefile module.  Makes no difference.
>>
>> Maybe it's happening on the other direction then, from url to File...
>> not sure. (we should move this discussion to the IRC channel, we're
>> flooding the ml)
>>
>> Cheers
>> Andrea
>>
>> --
>> Andrea Aime
>> OpenGeo - http://opengeo.org
>> Expert service straight from the developers.
>>
>

------------------------------------------------------------------------------
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to