Jody Garnett ha scritto: >> Jody Garnett ha scritto: >>> Very interesting; I would love it if you made this the default for the >>> accepts visitor method :-) >> I would love to get rid of that method. Jody, do you realize >> you're the only one pushing for that method and pretty much >> nobody else uses it? ;-) >> > Yeah - and I use it a lot as it takes away boiler plate code which I hate. > > However if we are going to do a featurecollection code sprint I am > willing to put it on the table. > >> I don't know. That's the very reason I asked for suggestions from >> people that do have more familiarity with concurrent utilities than >> me. > > I did not see anything amiss in your code; so no easy suggestions.
I did some more testing and it seems to be a matter of queue depth: - with a queue depth of 100 it may get to be 10% slower in some cases - with a queue depth of 1000 (which matches the fetch size we use by default with the database) it may be 5% slower in some cases - with a queue depth of 10000 it's always as fast or faster Same goes with shapefile backend, with higher queue depth I get higher performance. However, 10k might also mean using a lot of memory to keep in memory all those features. It's probably a good idea to make prefetching and queue size a user configurable thing. Maybe the best approach is to create a prefetching wrapper at the feature source level, which would return prefetching collections and thus prefetching iterators (in fact only the iterator would be prefetching, everything else would be there to inject prefetching at the map context construction level). Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
