Various errors in bounds computation
------------------------------------

                 Key: GEOT-2704
                 URL: http://jira.codehaus.org/browse/GEOT-2704
             Project: GeoTools
          Issue Type: Bug
          Components: data jdbc-ng
    Affects Versions: 2.5.7
            Reporter: Andrea Aime
            Assignee: Andrea Aime
             Fix For: 2.6-RC1


Looking into GEOT-2752 I've noticed the following bugs in the existing bounds 
computing algorithm:
- the Query propertyNames are ignored. However the bounds should be only about 
the features the Query extracts. If the query does not extract a geometry among 
the properties, the bounds should be empty. If a table has many geometries and 
the query extracts just one of them, the bounds should be relative to them
- the bounds query building code creates a select that extracts the bounds of 
all geometries, but the code that aggregates them ever only accesses the first

There is also something odd about the contract with the 
SqlDialect.encodeGeometryEnvelope, as it is not clear whether a single geometry 
envelope is to be extracted, or if an aggregation function is to be used.
The code tha aggregates the resulting envelopes in JDBCDataStore is setup to 
handle both cases. If that is to be expected the javadoc in SQLDialect should 
be amended to recommend the usage of an aggregate function and allow a fall 
back to a single geometry envelope extraction in case the first is not 
available. Thought, honestly, this would be very expensive, in that case the 
datastore api allows to just return a null to signify the computation was too 
expensive to be carried out.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to