Yeah, this was done to get around the 65k initializer method issue. I
thought I kept the variables static but i guess not. I think we can
probably keep them static but move the actual initialization into the
constructor of the singleton.
It might also make sense to separate the class into multiple schemas for
the different parts of the gml schema.
Some thoughts.
Ben Caradoc-Davies wrote:
> Justin, you are a champ! It looks like your xmlcodegen changes and
> instructions are just what we needed.
>
> Generated GMLSchema members are now non-static, which is an API change.
> More notes below.
>
> We still have to look at some details (ClientProperty/attribute
> handling, fixing app-schema breakages [static code]). I will do this
> next week.
>
> Thanks at lot, this change is a big help for encoding complex types.
>
> Kind regards,
> Ben.
>
>
> -------- Original Message --------
> Subject: GML bindings: working MeasureTypeBindingTest
> Date: Fri, 27 Nov 2009 15:35:47 +0800
> From: Ben Caradoc-Davies
> To: Rob Atkinson
> CC: Rini Angreani
>
> Rob A,
>
> good news: Justin's changes did the trick. I just got your
> MeasureTypeBindingTest to run. I also added a CodeTypeBindingTest. Don't
> get too excited, as the new non-static members break several app-schema
> tests (at compile time).
>
> All gt-xsd-gml3 unit tests pass.
>
> We are away on Monday on a field trip, so I thought I'd attach the patch
> - it includes Justin's changes, the generated GMLSchema, your patches,
> and my changes on top of them all - for your perusal. I'll be looking
> further at GEOT-2505 next week.
>
> Notes:
>
> - I followed Justin's instructions to generate xsd-gml3 GMLSchema (email
> now on GEOT-2505). I used "mvn -o xmlcodegen:generateSchemas" and had to
> manually add package and copyright.
>
> - I had to split the constructor in two to avoid the 64k method limit. I
> also added a SuppressWarnings("unchecked") and reformatted.
>
> - uom and codeSpace are in the null namespace, not gml
>
> - I added support for XML attributes in GeoAPI attributes for
> simple-content complex types, because this is what you created in your
> test harness.
>
> With these changes I could get MeasureTypeBindingTest and
> CodeTypeBindingTest to pass.
>
> We will talk next week.
>
> Kind regards,
>
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
