org.geotools.graph.util.PriorityQueue.update contains System.out.println()
--------------------------------------------------------------------------

                 Key: GEOT-3131
                 URL: http://jira.codehaus.org/browse/GEOT-3131
             Project: GeoTools
          Issue Type: Bug
    Affects Versions: 2.6.4
            Reporter: Jan Torben Heuer
            Priority: Trivial


org.geotools.graph.util.PriorityQueue.update contains an unnessesary sysout:

Also: does the actual implementation use linear search or not? this is not 
clear to me from the commented code.

 public void update(Object value) {
    Integer index = ((Integer)m_obj2index.get(value));
    if (index == null) {
      for (int i = 1; i < m_count; i++) {
        Object o = (Object)m_values[i];
        if (o == value) 
          System.out.println();
      }
    }
    update(index.intValue());
    //TODO: improve performance, dont use a linear search
//    for (int i = 1; i < m_values.length; i++) {
//      if (m_values[i] == value) {
//        update(i);
//        return;
//      }
//    }
  }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate 
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the 
lucky parental unit.  See the prize list and enter to win: 
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to