Jody Garnett wrote: > Right on Andrea :-) > > Only one comment inline... > >> - add support for pure side effect functions without return values >> (for what we know the process could make coffee and return nothing >> in electronic form) > > Does WPS support this? I have no problem with it but I cannot remember > it from the spec.
I thought it did, but looking at the DescribeProcess schema I see at least one output is required. And at least one input as well. Neither of them is actually a requirement in Java, and not a requirement in our process API either (a process could be a source of some kind with all the params built-in, think a random number generator, it is not required to have an input, thought you may make up some with a seed and a distribution kind). I'd leave it be for the moment. In order for the processes to work in the GeoServer WPS one needs to satisfy a series of requirements, like using only certain data types. I guess having at least one input and one output will add to that list (which sooner or later I'll have to write down somewhere). >> So, what do you think, good to come back in GeoTools? > > For sure :-) Cool. Any preference for a package? Also, shall we get rid of DEMTools, since it does nothing? >> Do you also want the JTS factory along with it (maybe it is of interest for >> uDig?) > > Yep. Ok. Another thing that I'd like to see is a similar factory that allows the processes to be classes instead of static methods. Something like: @DescribeProcess(...) public class MyProcess { public MyProcess() {}; @DescribeResult(....) public <resultType> execute(@DescribeParam(...) String p1, @DescribeParam(...) int p2, ...) throws Exception { ... } } And then I guess the factory would take a list of classes with the above annotations. A possible variant would be something that takes parameters as bean properties and has a execute method that takes no extra params (besides and eventual progress listener). Cheers Andrea ------------------------------------------------------------------------------ This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel