Ben Caradoc-Davies ha scritto: > The GeoTools trunk build has been failing under Java 5 since r36183 when > the Java 6 API was used in: > modules/library/render/src/main/java/org/geotools/renderer/style/ShapeMarkFactory.java > > This was a trivial API change: Java 6 added methods taking double args. > The fix was similarly trivia (convert literals to floats, in r36192).
Sigh, that was my fault, sorry. Was on a notebook on foss4g and only had java 6, did not notice. I assumed the build bot would catch any issue, but it did not happen. > This example is minor, but it illustrates two important points: > > (1) As far as I remember (and I am an email hoarder), GeoTools is still > a Java 5 project. Did we ever agree to upgrade to Java 6? I would > support this move, but we need to get the agreement of communities such > GeoServer and uDig. Until we do, developers should build with Java 5 to > ensure compatibility, and use Java 5 in in Eclipse as the project JRE. > Eclipse will check your source uses Java 5 language features (this is > configured in the pom), but it relies on the project JRE being set to > Java 5 to check the API. There was no vote to upgrade to Java 6 so far, we talked about it again at FOSS4G and there was no consensus to switch even with the more limited number of people discussing the issue. > (2) OpenGeo Hudson uses Java 6 to build GeoTools and so has no coverage > of Java 5 build failures. I found this build failure only because we > (CSIRO) use Java 5 on our buildbot. Any chance of reverting OpenGeo > Hudson to Java 5? I don't have the "keys" of this new buildbot but hope Justin can help. Or can provide someone else with the keys :-) However I believe Justin is travelling right now so don't expect a prompt response. Btw, dreaming aloud, it would be nice to keep the java 6 builds going and add the equivalent java 5 ones. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel