So what is happening with this and who's doing it? Cause this is quite related to what I am doing with the xlink/href patch. So I make it part of my patch? Or will it be dealt with separately?

On 05/10/10 17:55, Andrea Aime wrote:
On Tue, Oct 5, 2010 at 11:42 AM,<rini.angre...@csiro.au>  wrote:
Yes actually that'd be a good idea, since there's already validation at the end 
of creating a complex feature (cleanEmptyElements).
It also checks for xlink:href there, so it should cover all our problems.
The problem is the validation is called inside AttributeImpl() which is a super 
class of all attributes, outside of app-schema.
I think there's a custom attribute/feature factory for app-schema, and an 
AttributeBuilder class.
Perhaps we could then create an alternative non-validating constructor in 
AttributeImpl and ensure we use this one from these classes, so it'd only 
affect app-schema related attributes.
Dunno if it will work, it's just an idea I have right now.
Or even better, amend AttributeImpl not to validate its contents
automatically, just like it happens in simple features.
I actually think that automatic validation is a leftover of past times.
When switching to the new feature model we left the validation on for
the first few months for backwards compatibiliity
to make sure we were not unexpectedly breaking tests during the port
over, but then we turned it off.
Probably we forgot to do so in complex feature land

Cheers
Andrea

-----------------------------------------------------
Ing. Andrea Aime
Senior Software Engineer

GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054  Massarosa (LU)
Italy

phone: +39 0584962313
fax:     +39 0584962313

http://www.geo-solutions.it
http://geo-solutions.blogspot.com/
http://www.linkedin.com/in/andreaaime
http://twitter.com/geowolf

-----------------------------------------------------

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2&  L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel


--
*Niels Charlier*

Software Engineer
CSIRO Earth Science and Resource Engineering
Phone: +61 8 6436 8914

Australian Resources Research Centre
26 Dick Perry Avenue, Kensington WA 6151
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Geotools-devel mailing list
Geotools-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to