On Fri, Nov 26, 2010 at 4:11 AM, Niels <[email protected]> wrote: > Hi Justin and everyone, > > All what FilterFactoryImplNamespaceAware does, is creating AttributeImpl > objects with the NameSpace information written in its hits. These hints are > then picked up by the FeaturePropertyAccessor (also defined in app-schema) > who can evaluate properties with namespaces. > > I think what needs to happen is this. > The basic FilterFactory interface (and its impl) should support creating > properties with namespace information in their hints (optionally). This is > only a change of a few lines of code. The only concern here is, that > prefix:namespace mappings can be different per request or per file being > parsed. As a consequence, we cannot keep using one single filter factory > throughout the system, but rather need to create different instances > depending on namespace information, and the classes pass them ( optionally) > on to each other; the good thing is that the support to pass on filter > factory instance seems to already exist in many classes. > > In any case, there wouldn't be any need to build namespace support > everywhere overnight, since it remains an optional configuration option. > Namespace support can be built in gradually, I can start with where I need > it now (WMS) without hurting any other part of the system. > > Also, optionally, we could merge the classes FeaturePropertyAccessor and > XPathPropertyAccessor in to one, because these are basically doing the same > thing. It wouldn't be necessary for it to work, but it would be a > performance improvement.
This sounds like a plan. Gradual and optional introduction, I like the sound of that. Is there any way for you to show a bit more of how this would impact the system? Like a flow of small, well targeted patches, or a bigger one with some high level (aka small and concise) design doc with it? Cheers Andrea ----------------------------------------------------- Ing. Andrea Aime Senior Software Engineer GeoSolutions S.A.S. Via Poggio alle Viti 1187 55054 Massarosa (LU) Italy phone: +39 0584962313 fax: +39 0584962313 http://www.geo-solutions.it http://geo-solutions.blogspot.com/ http://www.linkedin.com/in/andreaaime http://twitter.com/geowolf ----------------------------------------------------- ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
