Great you are looking into it!
On 13-1-2011 3:20, Jody Garnett wrote:
I will tag Mark into the conversation as well.
I had a look earlier; when I was curious - there is code duplication
between the two pieces of work and it would be a good move to make a
JTS utility method that both pieces of code could call.
One thing we learned when doing the curve work was a bit of an
insight. We quickly implemented - a smooth interpolate from the start
to end point using a set angle.
This technique ran into problems when dealing with curves that formed
a coverage - because curves from touching polygons may not have
exactly the same start and end point for an edge the resulting curves
end up overlapping and generally causing problems.
We figured a better way to do it would be to follow what the JTS
buffer does; do a set number of divisions based on the compass
direction rather than start and end point - it would result in the
first and last line segment being a bit odd; but the would avoid the
polygon in polygon issue mentioned above.
Good point. I used (slightly modified) linearization code from the
Hibernate Spatial project. And it does suffer from the abovementioned
overlap flaw.
So I would accept the patch as is; and then refractor botht the
WKTReader and the GML curve code to call the same JTS utility method.
Jody
On 13/01/2011, at 11:42 AM, Justin Deoliveira wrote:
Hi Erik,
My apologies, this is the first I am seeing of this patch.
Unfortunately the component it was reported against was not "ext
xml-xsd" which is the umbrella component for all the xsd-* xml
modules. Bottom line the issue was not assigned to me so i missed it.
Anyways, this looks like a great contribution! We will definitely get
it into gt 2.7. We are planning for the beta1 release for tomorrow so
it is probably a bit late for that... but since there are no public
api changes in the patch (or none i saw on first glance) we can get
it into the next release.
I will try review the patch as soon as I can. Thanks again for the
contribution. More to come soon.
@Jody: You have done similar work supporting curves by linearizing to
jts. It would be good if you could review those parts of the patch.
-Justin
On Wed, Jan 12, 2011 at 3:18 PM, Jody Garnett <[email protected]
<mailto:[email protected]>> wrote:
I think we are just short on man power to help review patches;
you could contact the module maintainer and see if they could use
a hand.
You will find that several module have multiple maintainers; you
could always volunteer for this role.
Jody
On 13/01/2011, at 3:05 AM, Erik van de Pol wrote:
> Hi List,
>
> A while ago I submitted a patch for GML3 support for Arcs and
Circles:
> http://jira.codehaus.org/browse/GEOT-3324
>
> I think I would be a shame if it would not be included in
Geotools 2.7.
> If it does not get included now, there's a chance that it won't be
> compatible anymore with the trunk in the future.
>
> Is there anything I can do to get it included?
>
> --
> Met vriendelijke groeten,
>
> Erik van de Pol
> Software Ontwikkelaar
> B3Partners BV
> 030 214 2081
>
>
>
>
------------------------------------------------------------------------------
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them.
Understand
> malware threats, the impact they can have on your business, and
how you
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> Geotools-devel mailing list
> [email protected]
<mailto:[email protected]>
> https://lists.sourceforge.net/lists/listinfo/geotools-devel
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and
how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Geotools-devel mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Justin Deoliveira
OpenGeo - http://opengeo.org <http://opengeo.org/>
Enterprise support for open source geospatial.
--
Met vriendelijke groeten,
Erik van de Pol
Software Ontwikkelaar
B3Partners BV
030 214 2081
------------------------------------------------------------------------------
Protect Your Site and Customers from Malware Attacks
Learn about various malware tactics and how to avoid them. Understand
malware threats, the impact they can have on your business, and how you
can protect your company and customers by using code signing.
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
