It looks good to me so +1. My small niggle is the use of
query.getJoins().add(join1); where I might prefer: query.addJoin(join1); which might be easier for users to spot in the API. If you do stick with getJoins() is there are there good reasons to make it return a list over a collection? I can't work out if it is important to force an ordering to joins or not. Ian -- Ian Turton ------------------------------------------------------------------------------ Simplify data backup and recovery for your virtual environment with vRanger. Installation's a snap, and flexible recovery options mean your data is safe, secure and there when you need it. Data protection magic? Nope - It's vRanger. Get your free trial download today. http://p.sf.net/sfu/quest-sfdev2dev _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
