Comments "in line"
2011/6/26 Jody Garnett (JIRA) <[email protected]>
>
> [
> https://jira.codehaus.org/browse/GEOT-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=271477#comment-271477]
>
> Jody Garnett commented on GEOT-3669:
> ------------------------------------
>
> I would rather use the "user data" map to hold on to the index (and not
> violate information hiding by passing an index around).
That is fine for me.
Still patch looks fine and I will commit shortly.
>
Good.
> I have updated your patch with:
> - javadocs for the index(SimpleFeatureType) method
> - a check for FeatureType.getUserData().get("indexLookup")
> - I have left your index passing method around; however given the above
> change to index( SimpleFeatureType) you may no longer need it?
>
You are probably right. I'll check that out when the changes are committed.
>
> > Add SimpleFeatureImpl constructor which allows index to be set explicitly
> > -------------------------------------------------------------------------
> >
> > Key: GEOT-3669
> > URL: https://jira.codehaus.org/browse/GEOT-3669
> > Project: GeoTools
> > Issue Type: Improvement
> > Components: main
> > Affects Versions: 8.0-M0
> > Reporter: Kenneth Gulbrandsøy
> > Assignee: Jody Garnett
> > Priority: Minor
> > Attachments: SimpleFeatureImpl.patch
> >
> >
> > This is an optimization which prevents unnecessary rebuilding of the
> "attribute-name-to-value" index each time a new SimpleFeatureImpl is created
> with SimpleFeatureType implementations other than SimpleFeatureTypeImpl.
> This is the case in the unsupported EFeature module, where SimpleFeatureType
> is implemented as a inner class accessing EClass structure information.
> > The patch root is "../modules/main".
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
Cheers,
Kenneth
------------------------------------------------------------------------------
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security
threats, fraudulent activity, and more. Splunk takes this data and makes
sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
