Hello, Thanks very much for the feedback. I've created an issue with your suggestions together with a couple of queries of my own:
http://jira.codehaus.org/browse/GEOT-3927 Jody: any comments as DirectLayer Meister ? Michael On 23 October 2011 08:51, <lu...@plaintext.sk> wrote: > Hello, > > I have used in 8.0-M2 version of geotools MessageDirectLayer class and here > are my (I hope usefull) observations: > > - private static final String COLOR = "color"; Should be made public > > - add documentation to only one constructor: > /** > * <p> > * This class is able to do simplest watermark job. It will by default > display its > * message text in right botton corner of viewport. > * </p> > * > * <p> > * Sample code showing usage of this class: > * <code> > * MapContent map = new MapContent(); > * DirectLayer dl = new MessageDirectLayer("Text to be displayed"); > * dl.getUserData().put("color", Color.red); > * map.addLayer(dl); > * </code> > * </p> > * > * @param message message text which should be displayed > */ > > - what about to use some default color when color setting not presented? If > user does not set color property, it will print text with last used color, > thus with random color... > > ------------------------------------------------------------------------------ > The demand for IT networking professionals continues to grow, and the > demand for specialized networking skills is growing even more rapidly. > Take a complimentary Learning@Cisco Self-Assessment and learn > about Cisco certifications, training, and career opportunities. > http://p.sf.net/sfu/cisco-dev2dev > _______________________________________________ > Geotools-devel mailing list > Geotools-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/geotools-devel > ------------------------------------------------------------------------------ The demand for IT networking professionals continues to grow, and the demand for specialized networking skills is growing even more rapidly. Take a complimentary Learning@Cisco Self-Assessment and learn about Cisco certifications, training, and career opportunities. http://p.sf.net/sfu/cisco-dev2dev _______________________________________________ Geotools-devel mailing list Geotools-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel