I have added more tests to the patch and uploaded it to the JIRA issue:

http://jira.codehaus.org/browse/GEOT-3016

I have run the JDBC tests locally and all are successful. Can we review this 
for applying to tunk?

Cheers,

John

From: John Hudson [mailto:[email protected]]
Sent: Wednesday, 16 November 2011 1:50 PM
To: Jody Garnett
Cc: [email protected]
Subject: Re: [Geotools-devel] UUID Support

There is:

modules/library/jdbc/src/test/java/org/geotools/jdbc/JDBCUuidTest.java

tho it only tests getting features. I will fill it out a bit more.

From: Jody Garnett [mailto:[email protected]]
Sent: Wednesday, 16 November 2011 1:48 PM
To: John Hudson
Cc: 
[email protected]<mailto:[email protected]>
Subject: Re: [Geotools-devel] UUID Support

I suspect John that we need to write some test cases to confirm the 
functionality works (and remains working).

Did the patch include a JUnit test case? If not could you write one and attach 
it to the JIRA?

Thanks muchly,
Jody Garnett

--
Jody Garnett


On Wednesday, 16 November 2011 at 2:08 PM, John Hudson wrote:

Hello,



I have been working on getting a datastore with a primary key as a UUID and 
found this:



http://jira.codehaus.org/browse/GEOT-3016



I have applied it to the current trunk and have done some tests which show its 
working.



I noted the TODO’s on the JIRA:



1. Implement the UUID support into PostGisPsDialect

2. UUID insert/update
3. UUID as primary key



From my testing:



1. PostGisPsDialect  seems to be a pass-through to the PostGISDialect.java so 
should be left as is?

2. insert and update seem to be working

3. my lack of knowledge in this area means I’m not sure what this one really 
means



Is there a chance this patch can be reviewed and applied to the trunk ?



If more needs doing I’m happy to more this forward.



*a note about the patch – its double archived, to get to the actual patch you 
must unzip the file in the .gz file. – which is a actually a .patch extension.



My lack of understanding might have pointed me in the entirely wrong direction 
here, any pointers a definitely welcome.



Thanks for your time,



John Hudson

________________________________
The contents of this email are confidential and may be subject to legal or 
professional privilege and copyright. No representation is made that this email 
is free of viruses or other defects. If you have received this communication in 
error, you may not copy or distribute any part of it or otherwise disclose its 
contents to anyone. Please advise the sender of your incorrect receipt of this 
correspondence.
------------------------------------------------------------------------------
RSA(R) Conference 2012
Save $700 by Nov 18
Register now
http://p.sf.net/sfu/rsa-sfdev2dev1
_______________________________________________
Geotools-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/geotools-devel


________________________________
The contents of this email are confidential and may be subject to legal or 
professional privilege and copyright. No representation is made that this email 
is free of viruses or other defects. If you have received this communication in 
error, you may not copy or distribute any part of it or otherwise disclose its 
contents to anyone. Please advise the sender of your incorrect receipt of this 
correspondence.

________________________________
The contents of this email are confidential and may be subject to legal or 
professional privilege and copyright. No representation is made that this email 
is free of viruses or other defects. If you have received this communication in 
error, you may not copy or distribute any part of it or otherwise disclose its 
contents to anyone. Please advise the sender of your incorrect receipt of this 
correspondence.
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to