I thought about that; and we have two ways to consider simple. I don't really
want to stuff a Diff into ContentState that many implementations will ignore.
Extra stuff you are not using does end up being complex as well.
In anycase I will hook this up to PropertyDataStore and try out both
approaches; and go with what ever is easier to follow.
--
Jody Garnett
On Thursday, 24 November 2011 at 1:20 AM, Justin Deoliveira wrote:
>
>
> On Tue, Nov 22, 2011 at 4:37 PM, Jody Garnett <[email protected]
> (mailto:[email protected])> wrote:
> > I put up classes for an initial patch.
> >
> > As I copied the code across and ported I found nice clear spots for
> > everything. One change here is that we need a specific subclass of
> > ContentState in order to hold the Diff. It will be up to classes using the
> > Diff support to make use of this implementation.
> >
> Can we avoid the subclass, and just roll the diff into ContentState? Just
> trying to keep the number of classes to a minimum, which was one of the goals
> I had when I started working on ContentDataStore. Just a question, not a
> strong opinion, i am not really up to speed with the work that is going on.
>
> > I really like the idea of separating out the Transaction from the Event
> > support; however when implementing it appears as if the two concepts are
> > tied in order to support the batch feature events during commit() and
> > rollback().
> >
> > We could still ship a lightweight wrapper for Event notification but it
> > would need to consist of a feature writer and a transaction state hook.
> >
> > I also found I needed to pass the FeatureStore down to the writer
> > implementations in order to correctly send the event with an appropriate
> > indication of source. This is a pain as part of the fun here was to ensure
> > that ContentState had everything a writer needed to get the job done (so it
> > could be shared between writers working on the same transaction).
> >
> > --
> > Jody Garnett
> >
> >
> > On Tuesday, 22 November 2011 at 12:57 AM, Justin Deoliveira wrote:
> >
> > > Sounds like a good idea. Can't provide much feedback now... but will
> > > happily help review a patch once it's up.
> > >
> > > On Mon, Nov 21, 2011 at 2:52 AM, Andrea Aime
> > > <[email protected] (mailto:[email protected])>
> > > wrote:
> > > > (previously sent to geotools-users by mistake)
> > > >
> > > > Hi,
> > > > while I was working on shapefile-ng I noticed that ContentFeatureStore
> > > > does not provide
> > > > any help in supporting transactions and feature modification events,
> > > > so I've opened the following two
> > > > jiras:
> > > > http://jira.codehaus.org/browse/GEOT-3956
> > > > http://jira.codehaus.org/browse/GEOT-3955
> > > >
> > > > To implement those we could steal a page from AbstractDataStore, which
> > > > does provide both
> > > > by using writer wrappers that do send events and in memory transaction
> > > > support via
> > > > TransactionStateDiff
> > > >
> > > > Opinions?
> > > >
> > > > Cheers
> > > > Andrea
> > > >
> > > > --
> > > > -------------------------------------------------------
> > > > Ing. Andrea Aime
> > > > GeoSolutions S.A.S.
> > > > Tech lead
> > > >
> > > > Via Poggio alle Viti 1187
> > > > 55054 Massarosa (LU)
> > > > Italy
> > > >
> > > > phone: +39 0584 962313 (tel:%2B39%200584%20962313)
> > > > fax: +39 0584 962313 (tel:%2B39%200584%20962313)
> > > >
> > > > http://www.geo-solutions.it
> > > > http://geo-solutions.blogspot.com/
> > > > http://www.youtube.com/user/GeoSolutionsIT
> > > > http://www.linkedin.com/in/andreaaime
> > > > http://twitter.com/geowolf
> > > >
> > > > -------------------------------------------------------
> > > >
> > > >
> > > >
> > > > --
> > > > -------------------------------------------------------
> > > > Ing. Andrea Aime
> > > > GeoSolutions S.A.S.
> > > > Tech lead
> > > >
> > > > Via Poggio alle Viti 1187
> > > > 55054 Massarosa (LU)
> > > > Italy
> > > >
> > > > phone: +39 0584 962313 (tel:%2B39%200584%20962313)
> > > > fax: +39 0584 962313 (tel:%2B39%200584%20962313)
> > > >
> > > > http://www.geo-solutions.it
> > > > http://geo-solutions.blogspot.com/
> > > > http://www.youtube.com/user/GeoSolutionsIT
> > > > http://www.linkedin.com/in/andreaaime
> > > > http://twitter.com/geowolf
> > > >
> > > > -------------------------------------------------------
> > > >
> > > > ------------------------------------------------------------------------------
> > > > All the data continuously generated in your IT infrastructure
> > > > contains a definitive record of customers, application performance,
> > > > security threats, fraudulent activity, and more. Splunk takes this
> > > > data and makes sense of it. IT sense. And common sense.
> > > > http://p.sf.net/sfu/splunk-novd2d
> > > > _______________________________________________
> > > > Geotools-devel mailing list
> > > > [email protected]
> > > > (mailto:[email protected])
> > > > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> > >
> > >
> > >
> > > --
> > > Justin Deoliveira
> > > OpenGeo - http://opengeo.org
> > > Enterprise support for open source geospatial.
> > >
> > > ------------------------------------------------------------------------------
> > > All the data continuously generated in your IT infrastructure
> > > contains a definitive record of customers, application performance,
> > > security threats, fraudulent activity, and more. Splunk takes this
> > > data and makes sense of it. IT sense. And common sense.
> > > http://p.sf.net/sfu/splunk-novd2d
> > >
> > > _______________________________________________
> > > Geotools-devel mailing list
> > > [email protected]
> > > (mailto:[email protected])
> > > https://lists.sourceforge.net/lists/listinfo/geotools-devel
> > >
> > >
> > >
> >
> >
>
>
>
> --
> Justin Deoliveira
> OpenGeo - http://opengeo.org
> Enterprise support for open source geospatial.
>
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
Geotools-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
