Hi Andrea, On Tue, Dec 20, 2011 at 11:20 AM, Andrea Aime <[email protected]> wrote: >> There are two things that might still be considered regressions in there: >> - are we sure the password has to be specified along with the username? >> It's a bit of a stretch, but why don't we let it go and have the proxy >> decide if the password is required or not?
ok, the patch committed to GeoTools just takes that approach. >> - the http.nonProxyHosts is not supported. In simple setups it's not >> required, and I agree it might not be >> common in usage, but consider a case in which you have a server that's >> cascading two other servers, >> one that is local (a legacy in house WMS server that GeoServer is acting >> as a front-end for) and >> another is remote, with the proxy you can access the remote but not the >> local, and vice versa. >> >> It might be a good idea to have some sort of configuration allowing the >> usage of the java based http client instead so that also this case is >> covered, or we can try to match the nonProxyHost list >> (which would require some parsing and some regex usage, as the doc say >> "The value can be a list of hosts, each seperated by a |, and in addition a >> wildcard character (*) can be used for matching. For example: >> -Dhttp.nonProxyHosts="*.foo.com|localhost".") > Supporting nonProxyHosts would be good, but too risky this close to the release. At least I don't have the time to commit to make sure it works properly. But I do can add a config option in the GeoServer UI to enable one or the other (called "Use connection pooling" for example, a checkbox that enables/disables the maxConnections input, and under the hood instructs which http backend to use?). For when you wake up that should already be up on svn. Let me know if there's something to change. Cheers, Gabriel > > Btw, if you decide to go either way (config or parsing) just go for it, no > need for further reviews or discussions on my part. -- Gabriel Roldan OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps to sell to consumers worldwide. Explore the Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join http://p.sf.net/sfu/intel-appdev _______________________________________________ Geotools-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
