> > Likely to finish this week:
> > - https://github.com/geotools/geotools/tree/featurecollection_cleanup
> > -
> > https://github.com/geotools/geotools/blob/featurecollection_cleanup/modules/library/api/src/main/java/org/geotools/feature/FeatureCollection.java
> >
> > Is anyone ready?
> > a) Use ListFeatureCollection if add is required
> > b) Use FeatureIterator is iterator.close() is required
> >
> > Seems like lots of manual work without much of a fuss.
> > Make a GeoServer branch so that things get fixed
> >
> Took a quick look to access what will be needed for GeoServer. About 70 odd
> compile errors, most of them being the removal of add and the removal of
> plain iterator. All in all doesn't look too bad, sure there are probably a
> couple of corner cases in there but hopefully doable. So Jody when you are
> closer to completed the GeoTools end i will start in on GeoServer to help out.
Well I am closer, it all compiles. Next step is running tests, and converting
GeoServer.
Work is on the branch mentioned above.
The branch has numerous small commits as I cleaned up each module (in the hopes
of avoiding large conflicts).
The update.rst file includes code examples of how to perform the common fixes
needed when updating GeoServer.
There were a couple shaky areas where I could use a double check:
- the old FeatureCollectionIteration and subclass FilteringIteration used for
GML production
- anything to do with app-schema (there are so many cases where half way
through code ends up going from Feature to SimpleFeature). I did my best to
leave eel enough alone - but it scared me
- many cases where I was able to introduce try / finally in order to be sure of
closing an iterator
- the GML parsing classes often assume the FeatureCollection implements
Collection (they use DefaultFeatureCollection so this is a fair assumption -
which I now test with an instanceof check)
- StreamingRenderer was clear, however I expect aaime will not like the code
duplication (one loop for Collection/Iterator and another for
FeatureCollection/FeatureIterator)
Jody
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
