I'm currently waiting for the build to finish on my machine before pushing the removal of the module altogether. Just for the sake of clarity, I ( as part of the geogit team) did never support that module on the geotools codebase. It was Lisasoft's call to get it in and I made it very clear at the time that I did not have the time to support it on the geotools codebase. Then I suggested it was _moved_ to the geogit codebase so it doesn't bother on the geotools codebase. It was copied over but never removed, hence my latest proposal to remove it was just me volunteering in the best interest of geotools once I was told Lisasoft called itself out of the game, as I have nor had no mandate to do anything with that module.
So please go ahead with whatever improvement needs to be done on geotools and be sure the geogit team will keep on adapting to them on its own codebase and contributing back whenever necessary. Cheers, Gabriel On Mon, Dec 17, 2012 at 7:19 AM, Andrea Aime <[email protected]> wrote: > On Mon, Dec 17, 2012 at 11:15 AM, Ben Caradoc-Davies > <[email protected]> wrote: >> >> On 17/12/12 17:50, Andrea Aime wrote: >>> >>> Regardless, the store seems to be in their repo so this change would >>> likely end up breaking their build. >> >> >> Ah! They are downstream and consuming GeoTools master artifacts whose >> behaviour you are about to change? This is master, where behaviour and APIs >> change. You are quite considerate notifying them of your intentions, but I >> do not think this change should be delayed of possible problems (which will >> be detected by their CI). If this were stable, you would have a problem, but >> for most users this is a significant improvement and the type of change >> expected on master. > > > It's not even an API change, just an implementation change designed to > speedup fid filter evaluation. > >> >> >> Now I see that a bunch of stuff added by Niels is modified by these >> patches. You are not going to break app-schema in GeoTools or GeoServer, are >> you? :-) > > > Ah, back at the time the only failure was in geogit, not sure about today, I > hope Gonzalo gives it a shot since he's the one looking > for that patch to be applied? > > Cheers > Andrea > > > -- > == > Our support, Your Success! Visit http://opensdi.geo-solutions.it for more > information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > > ------------------------------------------------------------------------------ > LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial > Remotely access PCs and mobile devices and provide instant support > Improve your efficiency, and focus on delivering more value-add services > Discover what IT Professionals Know. Rescue delivers > http://p.sf.net/sfu/logmein_12329d2d > _______________________________________________ > GeoTools-Devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/geotools-devel > -- Gabriel Roldan OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
