Thanks Jody.
I have passed the contribution agreement up the ladder. Hopefully the bosses
can take care of that quickly. Should I get a pull request going now so people
can start reviewing it?
Thanks,
Yancy Matherne
Software Developer
Geocent, LLC
111 Veterans Blvd., Suite 1600
Metairie, LA 70005
O: (504) 831-1900
E: yancy.mathe...@geocent.com
http://www.geocent.com
________________________________
From: Jody Garnett [jody.garn...@gmail.com]
Sent: Friday, March 15, 2013 11:38 PM
To: Yancy Matherne
Cc: Justin Deoliveira; geotools-devel@lists.sourceforge.net
Subject: Re: [Geoserver-devel][Geotools-devel] NetCDF Plugin
Other than that I will take that as a request for commit access for a new
unsupported module[1]. With justin's support you have a +1 that the module is a
good idea :)
We do ask that module maintainers sign (even for unsupported modules) sign a
code contribution license (so the OSGeo Foundation can have copyright on the
code). The above link has fairly clear instructions, and there is a bit more on
the website[2], but since you already have a fork going it may be old news to
you.
If you need to bounce that contribution agreement off your employer, or have
any questions, pleas ask. It is a new contribution agreement so we are keen for
any feedback.
--
Jody Garnett
[1] http://docs.geotools.org/latest/developer/roles/commit.html
[2] http://docs.geotools.org/latest/developer/procedures/create.html
On Saturday, 16 March 2013 at 11:10 AM, Yancy Matherne wrote:
Hi All,
This is a continuation of a thread started in Geoserver-Devel list. I'm adding
the Geotools-Devel list since it was suggested that my code changes are be
suited in the GeoTools repository.
A little background for the new list of people. We are working on a NetCDF
coverage store plugin for GeoServer/GeoTools and would like to give it to the
open source community. NetCDF is a gridded data format used in the meteorology
and oceanography communities.
I made the suggested changes and moved it to my GeoTools fork:
https://github.com/geocent-yancy/geotools/tree/netcdf
I still need to update the README, just noticed it's a bit outdated. I may get
to it over the weekend, more likely on Monday. I also have to make another
branch or whatever for the GeoServer changes that will use the GeoTools NetCDF
plugin.
Thanks,
Yancy Matherne
Software Developer
Geocent, LLC
111 Veterans Blvd., Suite 1600
Metairie, LA 70005
O: (504) 831-1900
E: yancy.mathe...@geocent.com<mailto:yancy.mathe...@geocent.com>
http://www.geocent.com
________________________________
From: Justin Deoliveira [jdeol...@opengeo.org<mailto:jdeol...@opengeo.org>]
Sent: Thursday, March 14, 2013 10:38 AM
To: Yancy Matherne
Cc: Jody Garnett;
geoserver-de...@lists.sourceforge.net<mailto:geoserver-de...@lists.sourceforge.net>
Subject: Re: [Geoserver-devel] NetCDF Plugin
Hey Yancy,
Adding to Jody's comments I to think this makes more sense as a GeoTools pull
request. The only parts that need to remain in GeoServer could be the profile
that engates the dependency.
Also, I suggest you follow the packaging naming convention of
org.geotools.gce.netcdf.
-Justin
On Wed, Mar 13, 2013 at 5:31 PM, Yancy Matherne
<yancy.mathe...@geocent.com<mailto:yancy.mathe...@geocent.com>> wrote:
Thanks for the feedback. We can certainly make those changes. We were trying to
keep things simpler by having everything in one place. The NetCDFFormat can be
moved to geotools if that is appropriate, the licenses do not matter to us. We
actually have more test data but the files are unfortunately pretty big. We are
going to try to get some more test files that are slices of the big data.
Thanks,
Yancy Matherne
Software Developer
Geocent, LLC
111 Veterans Blvd., Suite 1600
Metairie, LA 70005
O: (504) 831-1900<tel:%28504%29%20831-1900>
E: yancy.mathe...@geocent.com<mailto:yancy.mathe...@geocent.com>
http://www.geocent.com
________________________________
From: Jody Garnett [jody.garn...@gmail.com<mailto:jody.garn...@gmail.com>]
Sent: Wednesday, March 13, 2013 6:11 PM
To: Yancy Matherne
Cc:
geoserver-de...@lists.sourceforge.net<mailto:geoserver-de...@lists.sourceforge.net>
Subject: Re: [Geoserver-devel] NetCDF Plugin
A couple small things:
You have added the following to your community/netcdf/pom.xml
<netcdf.version>4.2-min</netcdf.version>
<joda-time.version>1.5.2</joda-time.version>
Can we take those version numbers up to the root pom.xml in the dependency
management section, that way we have one place to manage "version hell" for the
project (which will help if two modules need joda-time for example).
As for netcdf/src/main/java/org/geocent/geotools/NetCDFFormat.java … is there a
reason this is not in the geotools library? Well other than GPL license …
Other than that some non useful feedback on style:
- If you can try for a class javadoc it helps those using an IDE
- NearestNeighbor implements IndexingStrategy .. we tend to use the interface
in the naming so the code reads well: NearestNeighborIndexingStrategy
It is great that you have sample data in support of tests, can you make a note
of where the sample data comes from? Say in your README.txt.
Cheers
--
Jody Garnett
On Thursday, 14 March 2013 at 8:36 AM, Yancy Matherne wrote:
Hi all,
I have our NetCDF plugin up on my GitHub now:
https://github.com/geocent-yancy/geoserver/tree/netcdf
We'd appreciate it if you could take a look before I make a pull request. We
realize it still has a ways to go before it is a general purpose NetCDF plugin.
But we would like to start getting some more eyes on it.
Thanks,
Yancy Matherne
Software Developer
Geocent, LLC
111 Veterans Blvd., Suite 1600
Metairie, LA 70005
O: (504) 831-1900<tel:%28504%29%20831-1900>
E: yancy.mathe...@geocent.com<mailto:yancy.mathe...@geocent.com>
http://www.geocent.com
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Geoserver-devel mailing list
geoserver-de...@lists.sourceforge.net<mailto:geoserver-de...@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Geoserver-devel mailing list
geoserver-de...@lists.sourceforge.net<mailto:geoserver-de...@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
--
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
