Hey Jody,

Answers inline.

On Tue, Aug 20, 2013 at 12:06 AM, Jody Garnett <[email protected]>wrote:

> Afternoon Justin:
>
> In yesterday's meeting you asked me to send email if I had any specific
> questions for you.
>
> You may be in position to answer questions on the Filter API?
>
> *Filter API *
>
> org/opengis/filter/capability/TemporalCapabilities.java
> org/opengis/filter/capability/Operator.java
> org/opengis/filter/capability/FilterCapabilities.java
> net-opengis-fes/Code/net/opengis/fes20/TemporalOperatorType.java
> org/opengis/filter/capability/FunctionName.java
> org/opengis/filter/capability/IdCapabilities.java
> org/opengis/filter/capability/ScalarCapabilities.java
> org/opengis/filter/capability/SpatialOperator.java
> org/opengis/filter/capability/SpatialCapabilities.java
>
> All of these files have: 2001-2004 EXSE, Department of Geography,
> University of Bonn
>
> /*
>  *    GeoTools - The Open Source Java GIS Toolkit
>  *    http://geotools.org
>  *
>  *    (C) 2011, Open Source Geospatial Foundation (OSGeo)
>  *    (C) 2005 Open Geospatial Consortium Inc.
>  *    (C) 2001-2004 EXSE, Department of Geography, University of Bonn
>  *                  lat/lon Fitzke/Fretter/Poth GbR
>  *
>  *    This library is free software; you can redistribute it and/or
>  *    modify it under the terms of the GNU Lesser General Public
>  *    License as published by the Free Software Foundation; either
>  *    version 2.1 of the License, or (at your option) any later version.
>  *
>  *    This library is distributed in the hope that it will be useful,
>  *    but WITHOUT ANY WARRANTY; without even the implied warranty of
>  *    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
>  *    Lesser General Public License for more details.
>  */
>
> And the question is: Was the content from the University contributed to
> GeoTools under CLA?
>

I actually have no idea. I have touched closes classes when we did the big
filter overhaul but no idea how they came into existence.

>
> Two options:
> - During OSGeo Incubation we made the point of contacting contributors and
> asking them to sign code contribution agreement. However if the above code
> is from deegree or something we may not of bothered (ie deegree is an LGPL
> project?).
> - Or perhaps the university donated the code to the OGC and we took a copy
> of it from the GeoAPI project (under the terms the OGC provide)
>
> *Temporal Filters*
> *
> *
> Next up some classes you added for WFS 2.0 implementation:
>
> org/geotools/filter/temporal/TEqualsImpl.java
> org/geotools/filter/temporal/BeforeImpl.java
> org/geotools/filter/temporal/TOverlapsImpl.java
> org/geotools/filter/temporal/BegunByImpl.java
> org/geotools/filter/temporal/AnyInteractsImpl.java
> org/geotools/filter/temporal/BinaryTemporalOperatorImpl.java
> org/geotools/filter/temporal/OverlappedByImpl.java
> org/geotools/filter/temporal/MeetsImpl.java
> org/geotools/filter/temporal/AfterImpl.java
> org/geotools/filter/temporal/BeginsImpl.java
> org/geotools/filter/temporal/MetByImpl.java
> org/geotools/filter/temporal/EndsImpl.java
> org/geotools/filter/temporal/TContainsImpl.java
> org/geotools/filter/temporal/DuringImpl.java
> org/geotools/filter/spatial/BBOX3DImpl.java
> org/geotools/temporal/TemporalConverterFactory.java
>
> The question is: Contributed or third party?
>
> These are all my original work.


> My take is:
>
> I think these are your original work, perhaps thanking the OGC for the
> class names (by way of the Filter 2.0 specification?)
>
> Sounds right to me.


> I also suspect the header date range may be wrong for classes such as
> TEquals.
>
> /*
>  *    GeoTools - The Open Source Java GIS Toolkit
>  *    http://geotools.org
>  *
>  *    (C) 2011, Open Source Geospatial Foundation (OSGeo)
>  *    (C) 2005, Open Geospatial Consortium Inc.
>  *
>  *    All Rights Reserved. http://www.opengis.org/legal/
>  */
>
> Since WFS 2.0 was only published in 2009 the above cannot be correct.
>

Hmmm... beats me. The date on the spec is 2010-11-02. We did the
implementation back in 2011 so i just threw that date on the header.



-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and 
AppDynamics. Performance Central is your source for news, insights, 
analysis and resources for efficient Application Performance Management. 
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to