On Wed, Jul 9, 2014 at 8:57 AM, Andrea Aime <[email protected]>
wrote:
> On Wed, Jul 9, 2014 at 2:52 PM, Justin Deoliveira <
> [email protected]> wrote:
>
>>
>>
>>
>> On Wed, Jul 9, 2014 at 2:11 AM, Andrea Aime <[email protected]
>> > wrote:
>>
>>> On Wed, Jul 9, 2014 at 2:22 AM, Justin Deoliveira <
>>> [email protected]> wrote:
>>>
>>>> Hi all,
>>>>
>>>> More mac issues... I am running into a test failure in the render
>>>> module.
>>>>
>>>> Failed tests:
>>>> GridCoverageRendererTest.testReprojectGoogleMercator:354 Images are
>>>> visibly different, found 3220 different pixels, against a threshold of 0
>>>> GridCoverageRendererTest.testRenderingBuffer:277 Images are visibly
>>>> different, found 5628 different pixels, against a threshold of 1000
>>>>
>>>> When I run in interactive mode the images look relatively similar, but
>>>> do differ in a number of places.
>>>>
>>>>
>>>> https://www.evernote.com/shard/s222/sh/8ea9043e-5dca-4be5-8a96-dc9f9cb03453/b7ff15dd511bc46a18402f0909e36185
>>>>
>>>
>>> googleMercator.png is a 200x206 -> 42100 pixels, meaning the difference
>>> is 13%.
>>> I guess we _could_ up the threshold?
>>>
>>> Ok... what do you think is an acceptable default upper limit? 20%?
>>
>
> Eh, difficult to say, that depends on the specific test.
>
>
>>
>>
>>> Btw, with the advanced raster projection handling for rasters you'll get
>>> much more tests with this map I'm afraid...
>>>
>>> Ok... in the interest of sanity for people on osx do you mind if we add
>> a flag to prevent failure in this case?
>>
>
> To just disable all image comparison tests on OSX? I guess if there is not
> enough dev time on OSX, it's the only way, right?
>
Yes, a system property that wouldn't be set by default but something that
could be set when problems like these arise.
Plenty of dev time on osx , but most of it being spent lately tracking down
these types of strange issues. I am not really that surprised that image
comparisons across platform would be brittle due to the number of variables
like jdk implementation, os make and version, etc...
Unfortunately I don't have the capacity to dig deeper in this case, and to
be quite honest I don't know the rendering chain well enough to be
effective at it.
>
> Cheers
> Andrea
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/NWWaa2 for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054 Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
--
Justin Deoliveira
VP Engineering | Boundless <http://boundlessgeo.com/>
[email protected]
@boundlessgeo <http://twitter.com/boundlessgeo/>
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel
