So, it turns out that Diff.NULL already exists - it was added at the same
time as the Initial DiffContentState implementation, but was never used. I
have updated everything to use it instead of TransactionStateDiff.NULL.
I have also rebased against you latest changes - we did a good job of
keeping our changes seperate, as I had no merge conflicts at all.
Updates have been added here: https://github.com/geotools/geotools/pull/685
Just so we are on the same page here, the main TODOs remaining for this
deprecation are:
- Migrate MemoryDataStore to use ContentDataStore instead of
AbstractDataStore -> This feels like it should be a seperate pull request
- Replace CollectionDataStore with the new inline implementation in
DataUtilities.
- Replace all uses of ArrayDataStore with DataUtilities.store(
DataUtilities.source( array ) )
Torben
On Tue, Jan 13, 2015 at 4:12 PM, Jody Garnett <jody.garn...@gmail.com>
wrote:
> I think it makes sense as part of the Diff class (brings the "Sentinel"
> object closer to the data structure it is used in).
>
> Please update your pull request and we can see what that looks like.
>
> --
> Jody Garnett
>
> On 13 January 2015 at 12:14, Torben Barsballe <tbarsba...@boundlessgeo.com
> > wrote:
>
>> Moving this to geotools-devel...
>>
>> On Tue, Jan 13, 2015 at 11:55 AM, Torben Barsballe <
>> tbarsba...@boundlessgeo.com> wrote:
>>
>>> Since this is used by Diff (Which is where it is actually added to the
>>> data) and DiffFeatureReader, it is not entirely internal to
>>> AbstractDataStore/ContentDataStore.
>>> As it stands, Diff writes this object to the feature map when a feature
>>> is removed. This value is then accessed by the TransactionDiff
>>> implementation (DiffTransactionState or TransactionStateDiff) and the
>>> FeatureSource (ContentFeatureSource or AbstractFeatureSource) to test if a
>>> feature is null.
>>> Consequently, we will need a single implementation (rather than a
>>> seperate copy). Since we are deprecating AbstractDataStore,
>>>
>>> Since TransactionStateDiff will be deprecated along with
>>> AbstractDataStore, we can move it to its ContentDataStore equivalent,
>>> DiffTransactionState. Alternatively, since the Diff class actually writes
>>> this object to the list of features, we could move it up a level to the
>>> Diff class.
>>>
>>> Torben
>>>
>>> On Tue, Jan 13, 2015 at 9:48 AM, Jody Garnett <jody.garn...@gmail.com>
>>> wrote:
>>>
>>>> This constant is only used internally (as a placeholder in the data
>>>> structure to mark deletions). The ContentDataStore support classes take a
>>>> copy of this placeholder (so it does not get caught up in the deprecation
>>>> cycle).
>>>>
>>>> --
>>>> Jody Garnett
>>>>
>>>
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
