Hi Andrea,
I cleaned up the code, added a few unit tests and created a pull request
<https://github.com/geotools/geotools/pull/736>.
This should be enough to fix the geometry parsing. As per your second
suggestion (creating a GeometryParsingException, which could be thrown in
case a geometry cannot be fixed and be selectively ignored by client code),
I'll implement it ASAP in a separate PR.
--SC
On Thu, Feb 12, 2015 at 4:04 PM, Stefano Costa <ridethepeng...@gmail.com>
wrote:
> On Thu, Feb 12, 2015 at 3:49 PM, Andrea Aime <andrea.a...@geo-solutions.it
> > wrote:
>
>> On Thu, Feb 12, 2015 at 3:48 PM, Andrea Aime <
>> andrea.a...@geo-solutions.it> wrote:
>>
>>>
>>> As for your previous suggestion, it makes sense too, but
>>> IllegalArgumentException is too generic... maybe we could create
>>> a GeometryParsingException (which extension IOException) that the
>>> ignorable exception listener could learn to ignore,
>>> and the OracleDialect could turn any failure calling SDO into one of
>>> those.
>>>
>>
>
>> Just a though... the better solution is to fix the geometry parsing (user
>>> data is sacred, software that does not handle it
>>> is just tossed away most of the time), but also having this one as an
>>> addition would not hurt.
>>>
>>>
>> And oh, that GeometryParsingException should be placed in gt-main, so
>> that other stores can use it as well
>>
>> Cheers
>> Andrea
>>
>>
> Bye,
> --SC
>
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
