On Sat, Feb 14, 2015 at 6:50 PM, Jody Garnett <jody.garn...@gmail.com>
wrote:
> I am travelling today. Agree about the mess, what does the spec do? And
> then let's make it consistent - will need to add a note to the rc1
> announcement.
>
A confirmation that it should be true by default from the filter encoding
spec:
<xsd:attribute name="matchCase" type="xsd:boolean"
use="optional" default="true"/>
About the note in the announcement, do we really need to? I mean, this bug
is years old, a search in our old svn via blame:
svn blame
http://svn.osgeo.org/geotools/trunk/modules/library/main/src/main/java/org/geotools/filter/FilterFactoryImpl.java
| less
gives us the following:
22666 jgarnett public PropertyIsEqualTo equals(Expression expr1,
Expression expr2) {
23177 jdeolive return equal( expr1,expr2,true);
22666 jgarnett }
23177 jdeolive
23177 jdeolive public PropertyIsEqualTo equal(Expression expr1,
Expression expr2, boolean matchCase) {
32736 jive return new
IsEqualsToImpl(this,expr1,expr2,matchCase);
23177 jdeolive }
23177 jdeolive
37241 NielsCharl public PropertyIsEqualTo equal(Expression expr1,
Expression expr2, boolean matchCase,
37241 NielsCharl MatchAction matchAction) {
37241 NielsCharl return new
IsEqualsToImpl(this,expr1,expr2,matchCase,matchAction);
37241 NielsCharl }
37241 NielsCharl
* 36470 NielsCharl public PropertyIsNotEqualTo notEqual(Expression
expr1, Expression expr2) {*
* 36470 NielsCharl return notEqual(expr1, expr2, false );*
* 36470 NielsCharl }*
36470 NielsCharl
23290 jdeolive public PropertyIsNotEqualTo notEqual(Expression
expr1, Expression expr2, boolean matchCase) {
23290 jdeolive return new
IsNotEqualToImpl(this,expr1,expr2,matchCase);
22735 jdeolive }
22735 jdeolive
37241 NielsCharl public PropertyIsNotEqualTo notEqual(Expression
expr1, Expression expr2, boolean matchCase,
37241 NielsCharl MatchAction matchAction) {
37241 NielsCharl return new
IsNotEqualToImpl(this,expr1,expr2,matchCase,matchAction);
37241 NielsCharl }
37241 NielsCharl
* 22666 jgarnett public PropertyIsGreaterThan greater(Expression
expr1, Expression expr2) {*
* 32736 jive return greater(expr1,expr2,false);*
* 22666 jgarnett }*
32736 jive
36470 NielsCharl public PropertyIsGreaterThan greater(Expression
expr1, Expression expr2, boolean matchCase) {
36470 NielsCharl return new IsGreaterThanImpl(this, expr1, expr2);
36470 NielsCharl }
36470 NielsCharl
37241 NielsCharl public PropertyIsGreaterThan greater(Expression
expr1, Expression expr2, boolean matchCase,
37241 NielsCharl MatchAction matchAction) {
37241 NielsCharl return new IsGreaterThanImpl(this, expr1, expr2,
matchAction);
37241 NielsCharl }
37241 NielsCharl
*22666 jgarnett public PropertyIsGreaterThanOrEqualTo
greaterOrEqual(Expression expr1,*
* 22666 jgarnett Expression expr2) {*
* 32736 jive return greaterOrEqual(expr1,expr2,false);*
* 22666 jgarnett }*
32736 jive
32736 jive public PropertyIsGreaterThanOrEqualTo
greaterOrEqual(Expression expr1,
32736 jive Expression expr2, boolean
matchCase) {
32736 jive return new
IsGreaterThanOrEqualToImpl(this,expr1,expr2,matchCase);
32736 jive }
37241 NielsCharl
37241 NielsCharl public PropertyIsGreaterThanOrEqualTo
greaterOrEqual(Expression expr1, Expression expr2,
37241 NielsCharl boolean matchCase, MatchAction matchAction) {
37241 NielsCharl return new
IsGreaterThanOrEqualToImpl(this,expr1,expr2,matchCase,matchAction);
37241 NielsCharl }
The commits in question are:
svn log -r 36470
http://svn.osgeo.org/geotools/trunk/modules/library/main/src/main/java/org/geotools/filter/FilterFactoryImpl.java
------------------------------------------------------------------------
r36470 | NielsCharlier | 2011-01-14 04:46:08 +0100 (ven, 14 gen 2011) | 1
line
XPath NamespaceSupport GEOT-3374
------------------------------------------------------------------------
svn log -r 32736
http://svn.osgeo.org/geotools/trunk/modules/library/main/src/main/java/org/geotools/filter/FilterFactoryImpl.java
------------------------------------------------------------------------
r32736 | jive | 2009-04-04 08:51:02 +0200 (sab, 04 apr 2009) | 1 line
remove referneces to geoapi layer, sld and go
------------------------------------------------------------------------
So if I read it correctly the wrong matchCase default was introduced by
you, and then Niels replicated it for the inequality case.
And I guess the implementation for matchCase were just never made besides
the PropertyIsEqualTo case (yes, I know
you just love tech debpt).
So.. it's a 6 years old issue. Do we need to report it in the RC1
announcement? I don't think so, it's wrong,
but apparently not affecting very many people, did not find any bug report
about it so far.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/NWWaa2 for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via Poggio alle Viti 1187
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
