On 14/04/15 00:52, Andrea Aime wrote: > On Mon, Apr 13, 2015 at 1:04 AM, Ben Caradoc-Davies <[email protected]> >> I would be happier if we made an even more brutal refactoring: a test with >> a fixture always runs; the *OnlineTest name pattern is used to turn on some >> classes with -Ponline. No more silent failures. Rip out the entire isOnline >> / skipOnFailure infrastructure. > > To do a online build of GeoTools this way one would need every dbms > installed and known to mankind... or resort to setup custom builds with > "-pl x,y,z -am -amd" > No eager to get into either of them.
No, what I mean is that only those tests with fixture configuration files present would run. If my local postgis is down, the gt-jdbc-postgis tests against it would fail rather than be silently skipped. Once configured, running an *offline* build becomes fiddly; I think this is your point. The trade-off is between test thoroughness and quicker tests that can be run more often. > I still prefer the current approach plus the fix I'm suggesting, it allows > to make a full online build selectively enabling what you can configure, > without having to > repeat oneself in both the config files and the maven command line I think your proposed change is an improvement. Kind regards, -- Ben Caradoc-Davies <[email protected]> Director Transient Software Limited <http://transient.nz> New Zealand ------------------------------------------------------------------------------ BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process modeling best practices with Bonita BPM through live exercises http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_ source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF _______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
