Thanks for the review Jim:
I've had a chance to review some the PR for the matrix branch.
>
> It looks like we'll need to follow up on
>
> 1. Any fixes for precision we want to sort out.
>
> Jody clearly fought a decent battle with something there. If this is
> unimportant, we can let it go. Otherwise, this may require digging into
> the new and old implementations until we find a subtle thing.
>
> 2. Removing unused classes and functions.
>
> The MatrixN's clone functions may not all work. (I confirmed that
> Matrix3.clone is broken.)
>
I also do not expect Serialization to remain the same, and have changed the
id used.
I'm a little unsure about how to view Point3d. If it is sufficiently
> internal, I wonder about making it protected in some manner. (This would
> require changing some unit tests.)
>
We can mark it as deprecated, Point3d is a parameter object as I did not
want to introduce a dependency on Coordinate or similar.
3. Git history clean-up.
>
> Andrea pointed out that there were multiple commits for the branch. I had
> goofed up while using a shared laptop and committed a few things as Alex
> rather than myself.
>
The plan is still to squash the commits when merging, thanks for the
reminder.
>
> Anyhow, I think we are getting close. Any feedback on the remaining
> issues is definitely appreciated. I'm happy to contribute some more, and
> I'd like to make sure that we don't duplicate efforts.
>
I am quite discouraged by the regression shown with GEOS-7009
<https://osgeo-org.atlassian.net/browse/GEOS-7009> - in particular the same
WMS request produces two different GetMap results (see the issue screen
snaps) I am not sure what to make of that as all our rendering tests pass
at the GeoTools level.
------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
