I have some questions about the proposal of pool request.
1. Should I finish at first the modifications of documentation and Schema
before publication of pool request? I have doubts about documentation - my
English is not good enough to write texts, that would be read by millions
of users all over the world.
2. I have an implementation of SVG images in InlineContent. I do understand
that it is the item of separate pull request. But some parts of the code,
dealing with SVG in InlineContent, will duplicate the code of the pull
request, dealing with expressions in InlineContent . That is not good. What
should I do in such a case? May be, it is reasonable to publish one pull
request, wich includes both items?
3. I have a look at Schema and found that CustomProperty element of
ExternalGraphic is absent in the Schema. But customProperties property of
ExternalGraphic is just the mechanism I have chosen for storing of the
InlineContent expression. I have decided that there is no need of extension
of ExternalGraphic interface when we have such universal thing as
customProperties. But now I'm not sure that I was right. I don't know, what
is worse - to extend the ExternalGraphic interface or to use
customProperties, which are absent in Schema. What can you advise me?
4. There is another problem, concerning the customProperties. In SLDParser I
am putting the parsed expression for InlineContent into customProperties
map. But original code of SLDParser uses the setCustomProperties method of
the ExternalGraphic interface for storing the result of parsing of
CustomProperty elements of SLD.
extgraph.setCustomProperties(paramList);
If I shall leave this code unchanged, then it will wipe off my data. So I
was to change this code.
Map <String, Object> properties = extgraph.getCustomProperties ();
if (properties == null) {
properties = new HashMap <>();
extgraph.setCustomProperties(properties)
}
properties.addAll(paramList);
I don't like this code. I think, that it will be better to use another code.
Map <String, Object> properties = extgraph.getCustomProperties ();
properties.addAll(paramList);
But it will not work, because in the implementation of ExternalGraphic
interface the variable for storing of customProperties is not initialized
and so we must use setCustomProperties method to assign it a value.
I should like to change the implementation of customProperties in
ExternalGraphicImpl class, initializing it in the constructor.But I suppose
that that changing of implementation of ExternalGraphicImpl is too much for
single pool request devoted to support of expressions in InlineContent. So
there is a repeating of the question 2. What should I do if pool request
demands modification of code, wich is weakly tied to the main issue of this
pool request?
5. Also I have a question about the modification of Schema. What is the
right technology for such modification? I suppose that it's not enough to
modify Symbolyzer.xsd. Should I use some code generator for modification of
xxxBinding classes? May I add UserParameter in Schema? I have great plans,
concerning it. Namely, I wish to implement the mechanism of dynamic change
of css properties of SVG shapes through SLD expressions. Using of
CustomProperty element of ExternalGraphic looks like a good solution for
such a task. Should I wait the result of discussion about separate Schema
for Geotools improvements?
--
View this message in context:
http://osgeo-org.1560.x6.nabble.com/InlineContent-expression-tp5220487p5220926.html
Sent from the geotools-devel mailing list archive at Nabble.com.
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
