That makes sense, I look forward to your pull request.

--
Jody Garnett

On 29 October 2015 at 01:17, Fernando Gonzalez <[email protected]
> wrote:

> Isn't it equivalent to the one of filtering the geometry out? In one
> case the SQL filters the geometry out, in yours the geometry is
> returned as null and is filtered out by null checks in render code.
>
> Andrea commented to check empty geometries on the render and I think
> it's the best since it would fix empty geometries coming from other
> sources, not only postgis. If no one has anything against, I'll try to
> produce a test case and a patch for that.
>
> Thanks!
>
> On 28 October 2015 at 18:06, Jody Garnett <[email protected]> wrote:
> > In addition to your two suggestions, Is it worth using a different
> > simplification function call (that does not produce empty muli-polygons)?
> >
> > --
> > Jody Garnett
> >
> > On 28 October 2015 at 09:37, Fernando Gonzalez
> > <[email protected]> wrote:
> >>
> >> Hi, let me draw your attention to this bug report[1] in geoserver.
> >>
> >> Basically, (1) reading geometries from postgis are producing
> >> MULTIPOLYGON EMPTY, (2) the renderer fails to render it (to ignore it,
> >> actually) and an exception is logged.
> >>
> >> Note that these empty geometries are produced by simplifying the
> >> geometry at rendering and a lot of these cases can happen, making the
> >> renderer "bail out".
> >>
> >> Can any of these two behaviors be considered a bug at the geotools
> >> level? Or should it be treated at the library user level (geoserver)?
> >>
> >> I suggest two possible corrections on the bug report but before
> >> submitting a pull request I would like to know your opinion about
> >> this.
> >>
> >> Best.
> >>
> >> [1] https://osgeo-org.atlassian.net/browse/GEOS-7243
> >>
> >> --
> >> Fernando González
> >> http://geomati.co/
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> _______________________________________________
> >> GeoTools-Devel mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/geotools-devel
> >
> >
>
>
>
> --
> Fernando González
> http://geomati.co/
>
------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to