Where can I add this configuration? I'm not aware of a GeoTools configuration file...
On Fri, Oct 30, 2015 at 12:39 PM, Andrea Aime <[email protected]> wrote: > Hi Patrick, > I was hoping that someone else would chime in and share an opinion, but > since no one > followed up, here is mine, to get started: this change breaks backward > compatibility, > which is bad enough, and also makes for hard to locate issues if people > forget to close > down writers properly (as often happens), which is worse. > > So my position is to have this behavior disabled by default, and enabled > by a flag or parameter. > Having a configurable batching size, defaulting to 1, would probably be a > good way, with > some documentation explaining the benefits and risks of increasing the > batch size to a > value greater than one > > Cheers > Andrea > > > > On Mon, Oct 26, 2015 at 9:59 AM, Patrick Valsecchi < > [email protected]> wrote: > >> While reviewing my batch insert pull request [1], Andrea Aime did a >> couple of coments [2] [3] that calls for a broader discussion. >> >> In summary, I'm trying to improve the GeoTools performance when inserting >> a lot of features in the DB. For that, I need to group the insertions >> together in order to leverage batch inserts. This is done by adding a >> buffer in JDBCInsertFeatureWriter that is flushed every 100 inserts and >> when the writer is closed. This can brake the code using it: >> >> - If the code closes the connection before the writer itgets an >> exception. >> - If the code forgets to close the writer and the connection, the >> features will be inserted when the GC wakes up. >> >> To me there are several solutions to that: >> >> - Put a warning in the release notes and let them fix the code. >> - Have the default buffer size set to 1 and have a parameter >> somewhere (where?) to change it. >> >> What's your take? >> >> >> Thanks. >> [1] https://github.com/geotools/geotools/pull/1009 >> [2] https://github.com/geotools/geotools/pull/1009#discussion_r42947268 >> [3] https://github.com/geotools/geotools/pull/1009#issuecomment-150946096 >> >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> GeoTools-Devel mailing list >> [email protected] >> https://lists.sourceforge.net/lists/listinfo/geotools-devel >> >> > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Andrea Aime > @geowolf > Technical Lead > > GeoSolutions S.A.S. > Via Poggio alle Viti 1187 > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > mob: +39 339 8844549 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > > ------------------------------------------------------- >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geotools-devel
