Looks good, let's call for PMC review (ie send an email and get this reviewed/approved).
-- Jody Garnett On 4 April 2016 at 01:58, Daniele Romagnoli < daniele.romagn...@geo-solutions.it> wrote: > Hi Jody, > I have updated the pull request as well as the proposal: > > https://github.com/geotools/geotools/wiki/Refactor-vector-mask-external-footprint-generation > > Basically, as per your suggestion, I have listed the main > classes/interfaces moved/extracted from gt-imagemosaic to gt-coverage with > a reference to the online javadoc. > Then, I have summarized the interfaces. > > Please, let me know if that looks good or if I should add some more. > > Best Regards, > Daniele > > > > On Fri, Apr 1, 2016 at 7:43 PM, Jody Garnett <jody.garn...@gmail.com> > wrote: > >> Hi Jody, >> >>> thanks for having setup a starting point. >>> I have question since I think it's the first time that a set of classes >>> is moved from a plugin module to a core one. >>> >>> Is there any convention/guidelines to follow up when setting up a >>> proposal for this kind of "move-classes refactoring"? (see next question) >>> >> >> It is just a normal proposal - we are making a chance that affects other >> developers and want to ask around first, check the release schedule, make >> sure you have enough resources to do the work, or give you an opportunity >> to ask for help. >> >> >>> In terms of coding, I have mainly moved couple of interfaces, related >>> implementing classes and auxiliary helper classes and enums from gt-mosaic >>> and gt-coverage. >>> What should I add in the "API change" part of the proposal? >>> >> >> Suggestions: >> - You could list the classes and provide links to their existing javadocs >> online >> - You could provide an outline of the classes since they are showing up >> as new public api and their may be questions >> >> >>> Should I simply add the "interfaces" (the API) in gt-coverage and avoid >>> listing every single class/variant implementing them, enums, utilities? >>> >> >> Yes, we are more concerned with showing the functionality change so >> project management committee members can approve the work. The proposal is >> about communication, the actual details we trust you to do as a committer / >> maintainer. >> >> >>> I also think that I shouldn't add before-after section for >>> gt-imagemosaic being a plugin, right? >>> >> >> Correct. >> >> Please, let me know. >>> >> >> Thanks for the email discussion, we can revise the proposal based on >> feedback. >> >> As someone who watches the docs I want to make sure there is a task to >> add a code example to the docs. Reminds me to pester Ian for raster >> symbolizer normalization docs ... >> > > > > -- > == > GeoServer Professional Services from the experts! Visit > http://goo.gl/it488V for more information. > == > > Ing. Daniele Romagnoli > Senior Software Engineer > > GeoSolutions S.A.S. > Via di Montramito 3/A > 55054 Massarosa (LU) > Italy > phone: +39 0584 962313 > fax: +39 0584 1660272 > > http://www.geo-solutions.it > http://twitter.com/geosolutions_it > > ------------------------------------------------------- > > *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003* > > Le informazioni contenute in questo messaggio di posta elettronica e/o > nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il > loro utilizzo è consentito esclusivamente al destinatario del messaggio, > per le finalità indicate nel messaggio stesso. Qualora riceviate questo > messaggio senza esserne il destinatario, Vi preghiamo cortesemente di > darcene notizia via e-mail e di procedere alla distruzione del messaggio > stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, > divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od > utilizzarlo per finalità diverse, costituisce comportamento contrario ai > principi dettati dal D.Lgs. 196/2003. > > > > The information in this message and/or attachments, is intended solely for > the attention and use of the named addressee(s) and may be confidential or > proprietary in nature or covered by the provisions of privacy act > (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection > Code).Any use not in accord with its purpose, any disclosure, reproduction, > copying, distribution, or either dissemination, either whole or partial, is > strictly forbidden except previous formal approval of the named > addressee(s). If you are not the intended recipient, please contact > immediately the sender by telephone, fax or e-mail and delete the > information in this message that has been received in error. The sender > does not give any warranty or accept liability as the content, accuracy or > completeness of sent messages and accepts no responsibility for changes > made after they were sent or for other risks which arise as a result of > e-mail transmission, viruses, etc. > >
------------------------------------------------------------------------------
_______________________________________________ GeoTools-Devel mailing list GeoTools-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geotools-devel
