On 8/6/2016 4:41 AM, Andrea Aime wrote:
On Sat, Aug 6, 2016 at 9:01 AM, Jody Garnett <jody.garn...@gmail.com <mailto:jody.garn...@gmail.com>> wrote:

    The sad part / danger / risk is that that our Filter interface
    would only be one kind of predicate, and I would expect normal
    java developers to make a query quickly in java code - which is
    something we cannot optimize.


No objections to having streams around, just make sure to properly document them and give warning to people
about performance issues.

As a suggestion, maybe it make sense to have FeatureSource.getFeatureStream() and FeatureSource.getFeatureStream(Filter) right next to each other.

Having a method which can either push-down a query or pull back all your data at runtime has me worried for large datasets.

Cheers,

Jim

From what I gathered in the discussion so far, it's a bit like hibernate, it can simplify things, but in order to use it efficiently one needs to understand how it works internally. Maybe indicate the docs examples of what will be efficiently sent down to the store for native translation, and what cannot be.

Wondering, are there risks about properly closing feature iterators here? If you are using visitor I guess not, but in that case there are other potential issues with our current interface, like inability to bail out of the iteration early.

Cheers
Andrea

--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==

Ing. Andrea Aime
@geowolf
Technical Lead

GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39  339 8844549

http://www.geo-solutions.it
http://twitter.com/geosolutions_it

*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*

Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.

The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.


-------------------------------------------------------


------------------------------------------------------------------------------
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel

Reply via email to