On Sat, Dec 17, 2016 at 11:31 PM, Ben Caradoc-Davies <b...@transient.nz>
wrote:
> Andrea,
>
> it looks like the problem was a race condition between the GC thread
> calling a finalizer for a data store leaked from another test and the
> stubbing setup for the test log handler, mediated by the shared
> ContentDataStore logger.
Ouch... that is evil.... good job locating the cause!
> Fix is to register the mock log handler only after stubbing is complete.
>
> Pull request for master:
> https://github.com/geotools/geotools/pull/1419
>
> With the fix, running all gt-jdbc tests passed 100 trials in Maven and
> over 20 in Eclipse.
>
I'm all in to merge the fix. +1
Thinking out loud, the logger keeps on being shared with other objects from
content data store
subclass, that might still be in the finalizer queue, those can still be
finalized while the test is running and
cause the log warning count to go up and break the test.
It is however probably just theoretical, as JDBCDataStore logs at SEVERE
level on finalize, and I don't see any
ready made way to force the code into using a new fresh logger... a small
change to ContentDataStore to
allow a subclass to instantiate its own logger would be needed.
Cheers
Andrea
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
