Ah ok, I thought you were discussing a library wide change
Cheers
Andrea
On Tue, May 30, 2017 at 4:52 PM, Jody Garnett <jody.garn...@gmail.com>
wrote:
> In this case Ben is trying to remove duplicate code that is currently in
> gt-referencing and gt-main into a common class. (So this is being done for
> code maintenance rather than change for changes sake).
>
> --
> Jody Garnett
>
> On 30 May 2017 at 00:37, Andrea Aime <andrea.a...@geo-solutions.it> wrote:
>
>> And I'd say "don't touch" :-) (take it as a -0)
>> I agree common conventions is good. And agree that we might want to set
>> one convention from here onwards.
>> But can we please do it without breaking backwards compatibility (or
>> possibly generating a lot of deprecated methods?).
>>
>> I'd suggest to put effort where (at least personally I feel it's) more
>> valuable, like helping users, writing docs, fixing bugs... but of course,
>> it's just me :-p
>>
>> Cheers
>> Andrea
>>
>>
>> On Tue, May 30, 2017 at 7:15 AM, Ben Caradoc-Davies <b...@transient.nz>
>> wrote:
>>
>>> Developers,
>>>
>>> Do you want "Urls" or "URLs"?
>>>
>>> Jody writes: "Please follow java naming conventions Urls renames to URLs"
>>>
>>> And I responded: "@jodygarnett we might need to put Urls vs URLs to a
>>> vote on the mailing list. Looking through the dependencies we have (visible
>>> from GeoServer gs-web-app Start) we have a huge mix of URL versus Url
>>> prefixes. There is at least one other Urls class out there. I think we ask
>>> the developers what they want. There is a modern style that three-letter
>>> acronyms get lowercase tail letters when forming CamelCase/PascalCase. Does
>>> this rule apply when adding an "s" in the style of "Lists", "Collections",
>>> and "Streams"? I thought yes, but happy to change it to match majority
>>> preference."
>>>
>>> Wiremock has an Urls class for its static URL helper methods.
>>>
>>> You say tomayto, I say tomahto, ...
>>>
>>> Kind regards,
>>> Ben.
>>>
>>>
>>> On 30/05/17 14:23, Ben Caradoc-Davies wrote:
>>>
>>>> I want to move the DataUtilities URL methods to new Urls class in
>>>> gt-metadata. Current methods will be retained and @deprecated:
>>>>
>>>> Jira:
>>>>
>>>> [GEOT-5740] Move DataUtilities URL methods to new Urls class in
>>>> gt-metadata
>>>> https://osgeo-org.atlassian.net/browse/GEOT-5740
>>>>
>>>> Pull request for master:
>>>>
>>>> [GEOT-5740] Move DataUtilities URL methods to new Urls class in
>>>> gt-metadata (master)
>>>> https://github.com/geotools/geotools/pull/1604
>>>>
>>>> The main change is that methods like DataUtilities.fileToURL and
>>>> DataUtilities.urlToFile become shorter: Urls.fileToUrl and
>>>> Urls.urlToFile respectively. There is a small amount of code preening. I
>>>> also updated the docs and examples to use the new API.
>>>>
>>>> Kind regards,
>>>>
>>>>
>>> --
>>> Ben Caradoc-Davies <b...@transient.nz>
>>> Director
>>> Transient Software Limited <http://transient.nz/>
>>> New Zealand
>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>
>>
>>
>> --
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> 55054 Massarosa (LU)
>> phone: +39 0584 962313 <+39%200584%20962313>
>> fax: +39 0584 1660272 <+39%200584%20166%200272>
>> mob: +39 339 8844549 <+39%20339%20884%204549>
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>>
>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>> principi dettati dal D.Lgs. 196/2003.
>>
>>
>>
>> The information in this message and/or attachments, is intended solely
>> for the attention and use of the named addressee(s) and may be confidential
>> or proprietary in nature or covered by the provisions of privacy act
>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>> Code).Any use not in accord with its purpose, any disclosure, reproduction,
>> copying, distribution, or either dissemination, either whole or partial, is
>> strictly forbidden except previous formal approval of the named
>> addressee(s). If you are not the intended recipient, please contact
>> immediately the sender by telephone, fax or e-mail and delete the
>> information in this message that has been received in error. The sender
>> does not give any warranty or accept liability as the content, accuracy or
>> completeness of sent messages and accepts no responsibility for changes
>> made after they were sent or for other risks which arise as a result of
>> e-mail transmission, viruses, etc.
>>
>> -------------------------------------------------------
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
>
--
==
GeoServer Professional Services from the experts! Visit
http://goo.gl/it488V for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
*AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
-------------------------------------------------------
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
