Hi,
this morning I've tried to come up with a minimal checkstyle validation
that we could enable
right after IntelliJ reformat... so far I came up empty, like, there are
hundreds (or more) of violations left
for even the most basic checks (like, not even tabs checks would pass).
To do these tests I setup a new branch with a different way of setting up
checkstyle (inline configuration
instead of in a separate module), set it up to ignore generated code
(javacc, EMF).
The branch is here:
https://github.com/aaime/geotools/commits/intellij_checkstyle2
and the configuration of checkstyle, with all checks I've tried commented
out, and the number or errors
originating from each:
https://github.com/aaime/geotools/commit/384564d764705d8b06d4e72bb72bde1ad58b06af#diff-600376dffeb79835ede4a0b285078036R1766
and finally a reference to the checks, so that you can read what the
commented out modules do:
http://checkstyle.sourceforge.net/checks.html
This is... depressing. The notion of wholesale reformat was based on two
ideas:
- Automatic reformat on all branches
- A set of checks to maintain basic compliance after that is done (or
we'll just go back to the previous state, soon)
It seems the second element, which is kind of important, cannot be achieved
without further source code
processing. Some could hopefully be automated, like tabs replacement in
javadocs, but various things seem like they'd
have to be manual (and let's not forget the need for backport, or we'd be
generating a backport hell for any new
bugfix/feature in the next year to come).
At this point, without a code sprint dedicated to this, I am afraid that we
would be able to only do wholesale
reformat, but without checks, unless we adopt the Google code style and
tools (which we don't like the formatting of).
Help? Opinions? :-)
Cheers
Andrea
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Ing. Andrea Aime
@geowolf
Technical Lead
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
phone: +39 0584 962313
fax: +39 0584 1660272
mob: +39 339 8844549
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o
nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
loro utilizzo è consentito esclusivamente al destinatario del messaggio,
per le finalità indicate nel messaggio stesso. Qualora riceviate questo
messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
darcene notizia via e-mail e di procedere alla distruzione del messaggio
stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
utilizzarlo per finalità diverse, costituisce comportamento contrario ai
principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for
the attention and use of the named addressee(s) and may be confidential or
proprietary in nature or covered by the provisions of privacy act
(Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction,
copying, distribution, or either dissemination, either whole or partial, is
strictly forbidden except previous formal approval of the named
addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the
information in this message that has been received in error. The sender
does not give any warranty or accept liability as the content, accuracy or
completeness of sent messages and accepts no responsibility for changes
made after they were sent or for other risks which arise as a result of
e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
