See other messages, if we go for Google tooling plus AOSP convention, no
need to discuss, 100 cold it is and not changeable. So.. :-p
Cheers
Andrea
Il 18 Mar 2018 22:27, "Ben Caradoc-Davies" <b...@transient.nz> ha scritto:
> +0.
>
> tl;dr: Doodle poll of all developers? Options: 72, 80, 100, 120, and 150
> columns. Reduce comment width to match.
>
> I am not opposed, but I use the extra horizontal screen real estate for
> larger fonts and Eclipse Package Explorer and Outline. Very deep nesting is
> a code smell that suggests refactoring is needed. And very wide lines might
> suggest a Java developer who has not yet discovered the import keyword. ;-)
>
> Shorter lines can be more readable. 100 columns is already quite long.
> Typesetters target 66 characters per line for English prose, and Project
> Gutenberg asks for 60-70, with an upper limit of 80. The Linux kernel still
> uses 80 (and they are filthy tab-indenters):
> https://www.kernel.org/doc/html/v4.15/process/coding-style.html
>
> In my current font (Deja Vu Sans Mono 12pt) I can see 85 columns in a
> GitHub pull request diff.
>
> If we give Java a extra indentations for class blocks, 100 seems quite
> generous, but then we also have anonymous inner classes, and giant
> identifiers such as FactoryFactoryFactory class names and methods that
> useTheMethodNameInsteadOfJavadocOhPleaseWhatWereYouThinking (I am guilty
> of this one). I am surprised that IDEs do not offer identifier folding. I
> think we need a Doodle poll.
>
> I also note that comment width was increased to 150 several years ago:
>
> "relax formatting for javadocs to 150 chars to prevent messing up src
> reference"
> https://github.com/geotools/geotools/commit/fecd5a601bc0dcee
> 1e47d7544fb3e6ac32017f9d
>
> AFAIK we no longer use @source in javadocs. I would like the comment
> length reduced to whatever we use for code, for consistency and legibility.
>
> Kind regards,
> Ben.
>
>
> On 18/03/18 20:55, Andrea Aime wrote:
>
>> Hi,
>> along with the "wholesale reformat" proposal I would like to add a small
>> change to our
>> coding convetion: switching the max line length from 100 to 120 chars.
>>
>> The 100 chars limit was set many years ago, screens form factor changed in
>> the meantime
>> and having widescreens is now the norm.
>>
>> As a further context, the Google coding conventions limit to 100 columns,
>> but with a 2 space
>> indent they allow far more "nesting" than our current setup (maybe too
>> much, 120 chars
>> with 4 space indent seems a better compromise to me).
>>
>> Cheers
>> Andrea
>>
>> ==
>> GeoServer Professional Services from the experts! Visit
>> http://goo.gl/it488V
>> for more information.
>> ==
>>
>> Ing. Andrea Aime
>> @geowolf
>> Technical Lead
>>
>> GeoSolutions S.A.S.
>> Via di Montramito 3/A
>> 55054 Massarosa (LU)
>> phone: +39 0584 962313
>> fax: +39 0584 1660272
>> mob: +39 339 8844549
>>
>> http://www.geo-solutions.it
>> http://twitter.com/geosolutions_it
>>
>> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>>
>> Le informazioni contenute in questo messaggio di posta elettronica e/o
>> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
>> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
>> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
>> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
>> darcene notizia via e-mail e di procedere alla distruzione del messaggio
>> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
>> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
>> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
>> principi dettati dal D.Lgs. 196/2003.
>>
>> The information in this message and/or attachments, is intended solely for
>> the attention and use of the named addressee(s) and may be confidential or
>> proprietary in nature or covered by the provisions of privacy act
>> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
>> Code).Any use not in accord with its purpose, any disclosure,
>> reproduction,
>> copying, distribution, or either dissemination, either whole or partial,
>> is
>> strictly forbidden except previous formal approval of the named
>> addressee(s). If you are not the intended recipient, please contact
>> immediately the sender by telephone, fax or e-mail and delete the
>> information in this message that has been received in error. The sender
>> does not give any warranty or accept liability as the content, accuracy or
>> completeness of sent messages and accepts no responsibility for changes
>> made after they were sent or for other risks which arise as a result of
>> e-mail transmission, viruses, etc.
>>
>>
>>
>> ------------------------------------------------------------
>> ------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>
>>
>>
>> _______________________________________________
>> GeoTools-Devel mailing list
>> GeoTools-Devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>
>>
> --
> Ben Caradoc-Davies <b...@transient.nz>
> Director
> Transient Software Limited <https://transient.nz/>
> New Zealand
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
