Cool, thanks guys, happy (re)formatting ;0
On Tue, Mar 20, 2018 at 10:10 AM Andrea Aime <andrea.a...@geo-solutions.it>
wrote:
> Hi Eric,
> we discussed it at today's PSC meeting, I'm going to propose the 4 spaced
> one (for official vote), the bulk of the
> core devs are used to it, and for a very long time.
>
> Cheers
> Andrea
>
>
> On Mon, Mar 19, 2018 at 5:41 PM, Eric Engle <een...@google.com> wrote:
>
>> Just my $.02, as a long-time lurker who would love to simplify
>> contributions as much as possible: I use 2 space indentation in my day job,
>> and contributing some of that work upstream to you is certainly simpler if
>> that also uses two spaces ;-]
>>
>> Best regards,
>>
>> Eric
>>
>>
>> On Sun, Mar 18, 2018 at 3:22 AM Ian Turton <ijtur...@gmail.com> wrote:
>>
>>>
>>>
>>> On 18 March 2018 at 09:49, Andrea Aime <andrea.a...@geo-solutions.it>
>>> wrote:
>>>
>>>> Hi,
>>>> given the issues on the intellij + checkstyle approach I had a second
>>>> look at the google variant
>>>> and cleaned up the branch to have a good separation of pom changes and
>>>> reformats:
>>>>
>>>> https://github.com/aaime/geotools/tree/intellij_checkstyle2
>>>>
>>>> Indeed, it took 3 runs to get to a stable formatting, you can see them
>>>> as separate commits and check
>>>> the changes occurred in each:
>>>> https://github.com/aaime/geotools/tree/google_format
>>>>
>>>> Looking at the code, I'm suffering from mild nausea... that said, the
>>>> same happened when I switched
>>>> from Eclipse to IntelliJ a few months ago, was sick for a week but then
>>>> it went away.
>>>>
>>>>
>>> From the quick look I've had it isn't too bad, I quite like 2 spaces per
>>> tab (I used it for local projects for a while).
>>>
>>> TBH I'm less concerned about what it looks like and more concerned that
>>> it is maintainable going forward.
>>>
>>>
>>> Thanks for experimenting with this.
>>>
>>>
>>> Ian
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>>> _______________________________________________
>>> GeoTools-Devel mailing list
>>> GeoTools-Devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/geotools-devel
>>>
>>
>
>
> --
>
> Regards,
>
> Andrea Aime
>
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/it488V for more information.
> ==
>
> Ing. Andrea Aime
> @geowolf
> Technical Lead
>
> GeoSolutions S.A.S.
> Via di Montramito 3/A
> 55054 Massarosa (LU)
> phone: +39 0584 962313
> fax: +39 0584 1660272
> mob: +39 339 8844549
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
