Ah! I had the same issue as Ian in one of my open PR
(I used a non valid formatation for a JavaDoc), happy to see this check working
:)
On 05/08/2018 03:06 PM, Andrea Aime wrote:
Hi Ian,
yes, it's the check that I added to make sure the files were always properly formatted before
checking.
The formatting happens during the build, and there is a check in a profile that fails the build if
further
changes happen on Travis.
Thinking about it, it would probably be best to switch the behavior from
formatting and then checking
for local modifications, to just formatting check...
Cheers
Andrea
On Tue, May 8, 2018 at 3:59 PM, Ian Turton <ijtur...@gmail.com
<mailto:ijtur...@gmail.com>> wrote:
I'm seeing a fail in Travis (https://github.com/geotools/geotools/pull/1878
<https://github.com/geotools/geotools/pull/1878>) that I've never noticed
before, I'm
wondering if it is due to the reformatting?
All the tests pass as expected but it then fails due to a local
modification.
Here is the relevant part of the log:
Tests run: 357, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ gt-xsd-filter ---
[INFO] Building jar:
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT.jar
[INFO]
[INFO] --- maven-jar-plugin:2.4:test-jar (default) @ gt-xsd-filter ---
[INFO] Building jar:
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT-tests.jar
[INFO]
[INFO] >>> maven-source-plugin:2.2.1:jar (attach-sources) > generate-sources @
gt-xsd-filter >>>
[INFO]
[INFO] --- git-commit-id-plugin:2.1.15:revision (default) @ gt-xsd-filter
---
[INFO]
[INFO] <<< maven-source-plugin:2.2.1:jar (attach-sources) < generate-sources @
gt-xsd-filter <<<
[INFO]
[INFO]
[INFO] --- maven-source-plugin:2.2.1:jar (attach-sources) @ gt-xsd-filter
---
[INFO] Building jar:
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT-sources.jar
[INFO]
[INFO] --- maven-install-plugin:2.4:install (default-install) @
gt-xsd-filter ---
[INFO] Installing
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT.jar
to
/home/travis/.m2/repository/org/geotools/xsd/gt-xsd-filter/20-SNAPSHOT/gt-xsd-filter-20-SNAPSHOT.jar
[INFO] Installing
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/pom.xml
to
/home/travis/.m2/repository/org/geotools/xsd/gt-xsd-filter/20-SNAPSHOT/gt-xsd-filter-20-SNAPSHOT.pom
[INFO] Installing
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT-tests.jar
to
/home/travis/.m2/repository/org/geotools/xsd/gt-xsd-filter/20-SNAPSHOT/gt-xsd-filter-20-SNAPSHOT-tests.jar
[INFO] Installing
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter/target/gt-xsd-filter-20-SNAPSHOT-sources.jar
to
/home/travis/.m2/repository/org/geotools/xsd/gt-xsd-filter/20-SNAPSHOT/gt-xsd-filter-20-SNAPSHOT-sources.jar
[INFO]
[INFO] --- maven-scm-plugin:1.9.5:check-local-modification (exec1) @
gt-xsd-filter ---
[INFO] Executing: /bin/sh -c cd
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter && git
rev-parse --show-toplevel
[INFO] Working directory:
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter
[INFO] Executing: /bin/sh -c cd
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter && git
status --porcelain .
[INFO] Working directory:
/home/travis/build/geotools/geotools/modules/extension/xsd/xsd-filter
[ERROR] The build will stop as there is local modifications
--
Ian Turton
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
<mailto:GeoTools-Devel@lists.sourceforge.net>
https://lists.sourceforge.net/lists/listinfo/geotools-devel
<https://lists.sourceforge.net/lists/listinfo/geotools-devel>
--
Regards,
Andrea Aime
==GeoServer Professional Services from the experts! Visit http://goo.gl/it488V for more
information.==Ing. Andrea Aime @geowolfTechnical LeadGeoSolutions S.A.S.Via di Montramito 3/A55054
Massarosa (LU)phone: +39 0584 962313fax: +39 0584 1660272mob: +39 339
8844549http://www.geo-solutions.ithttp://twitter.com/geosolutions_it
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i file/s allegato/i
sono da considerarsi strettamente riservate. Il loro utilizzo è consentito esclusivamente al
destinatario del messaggio, per le finalità indicate nel messaggio stesso. Qualora riceviate
questo messaggio senza esserne il destinatario, Vi preghiamo cortesemente di darcene notizia via
e-mail e di procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro sistema.
Conservare il messaggio stesso, divulgarlo anche in parte, distribuirlo ad altri soggetti,
copiarlo, od utilizzarlo per finalità diverse, costituisce comportamento contrario ai principi
dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use
of the named addressee(s) and may be confidential or proprietary in nature or covered by the
provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution,
or either dissemination, either whole or partial, is strictly forbidden except previous formal
approval of the named addressee(s). If you are not the intended recipient, please contact
immediately the sender by telephone, fax or e-mail and delete the information in this message that
has been received in error. The sender does not give any warranty or accept liability as the
content, accuracy or completeness of sent messages and accepts no responsibility for changes made
after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Regards,
Nuno Oliveira
==
GeoServer Professional Services from the experts! Visit http://goo.gl/it488V
for more information.
==
Nuno Miguel Carvalho Oliveira
@nmcoliveira
Software Engineer
GeoSolutions S.A.S.
Via di Montramito 3/A
55054 Massarosa (LU)
Italy
phone: +39 0584 962313
fax: +39 0584 1660272
http://www.geo-solutions.it
http://twitter.com/geosolutions_it
-------------------------------------------------------
AVVERTENZE AI SENSI DEL D.Lgs. 196/2003
Le informazioni contenute in questo messaggio di posta elettronica e/o nel/i
file/s allegato/i sono da considerarsi strettamente riservate. Il loro utilizzo
è consentito esclusivamente al destinatario del messaggio, per le finalità
indicate nel messaggio stesso. Qualora riceviate questo messaggio senza esserne
il destinatario, Vi preghiamo cortesemente di darcene notizia via e-mail e di
procedere alla distruzione del messaggio stesso, cancellandolo dal Vostro
sistema. Conservare il messaggio stesso, divulgarlo anche in parte,
distribuirlo ad altri soggetti, copiarlo, od utilizzarlo per finalità diverse,
costituisce comportamento contrario ai principi dettati dal D.Lgs. 196/2003.
The information in this message and/or attachments, is intended solely for the attention and use of the named addressee(s) and may be confidential or proprietary in nature or covered by the provisions of privacy act (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection Code).Any use not in accord with its purpose, any disclosure, reproduction, copying, distribution, or either dissemination, either whole or partial, is strictly forbidden except previous formal approval of the named addressee(s). If you are not the intended recipient, please contact immediately the sender by telephone, fax or e-mail and delete the information in this message that has been received in error. The sender does not give any warranty or accept liability as the content, accuracy or completeness of sent messages and accepts no responsibility for changes made after they were sent or for other risks which arise as a result of e-mail transmission, viruses, etc.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
