Thanks, Brad. I think this is a good change, so +1 from me.
Here is the corresponding GeoServer change:
https://github.com/geoserver/geoserver/pull/3019
There are two types of downstream breakages. The first are downstream
tests that use XMLTestSupport and so need to depend on the new
gt-xsd-core tests artifact:
<dependency>
<groupId>org.geotools.xsd</groupId>
<artifactId>gt-xsd-core</artifactId>
<classifier>tests</classifier>
<scope>test</scope>
</dependency>
The second are downstream tests that were using xmlunit as a transitive
dependency via gt-xsd-core but not XMLTestSupport. As Brad has noted and
fixed in his PR, the main gt-xsd-core artifact should not depend on
xmlunit. These downstream tests that use xmlunit but not XMLTestSupport
need only declare a test dependency on xmlunit:
<dependency>
<groupId>xmlunit</groupId>
<artifactId>xmlunit</artifactId>
<scope>test</scope>
</dependency>
Please let us know if you find any other affected downstream projects.
Does anyone object to this API change?
Kind regards,
Ben.
On 24/07/18 13:53, br...@frogmouth.net wrote:
https://github.com/geotools/geotools/pull/1986 is a proposal to remove
xmlunit (and junit) as dependencies we ship in geotools.
The reason why we were providing that is partly because some of the
dependency definitions were not test scoped, and partly because we actually
do depend on it, for one class - org.geotools.xml.test.XMLTestSupport
(http://docs.geotools.org/latest/javadocs/org/geotools/xml/test/XMLTestSuppo
rt.html)
I propose (see PR) to remove XMLTestSupport from the GeoTools XML API and
provide it only as a test-jar. That has impact on at least GeoServer, and
Ben Caradoc Davies has developed a corresponding PR.
That is an API/ABI break, and backport is not intended. Given the nature of
the changes in 20.0, I don't think this is a particularly onerous change if
anyone else is using that class.
I request approval for this change.
Brad
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
--
Ben Caradoc-Davies <b...@transient.nz>
Director
Transient Software Limited <https://transient.nz/>
New Zealand
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
GeoTools-Devel mailing list
GeoTools-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/geotools-devel
